Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make backprop faster #8

Open
jlbosse opened this issue Jul 19, 2023 · 2 comments
Open

Make backprop faster #8

jlbosse opened this issue Jul 19, 2023 · 2 comments

Comments

@jlbosse
Copy link
Collaborator

jlbosse commented Jul 19, 2023

Currently, the function expect_g(op::AbstractAdd, reg::MajoaranaReg) takes time O(n^3) because of the full matrix-matrix product. It may be possible to speed this up by not instantiating the full matrix form of op in the Majorana basis.

@jlbosse
Copy link
Collaborator Author

jlbosse commented Jul 20, 2023

Related: expect can probably also be made faster if I find a way to create the majoranasquares matrix faster by e.g. collecting all the terms first and then creating the sparse matrix from (I, J, V) https://docs.julialang.org/en/v1/stdlib/SparseArrays/#Sparse-Vector-and-Matrix-Constructors?

@jlbosse
Copy link
Collaborator Author

jlbosse commented Oct 17, 2023

#10 made significant progress on this. I should check if the big-O scaling is the correct one now and close this if yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant