Drop untrusted values from trusted proxy headers #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonk52
force-pushed
the
drop-untrusted-proxy-values
branch
from
d0f82c1
to
8f321fa
Compare
|
There is no reason to return a new |
Headers such as X-Forwarded-For, X-Forwarded-Host and Forwarded can contain more values than are actually trusted, leading to the possibility that the downstream application could interpret those headers differently to waitress. This change rewrites the trusted headers so that they only contain the values from the trusted proxies.
simonk52
force-pushed
the
drop-untrusted-proxy-values
branch
from
8f321fa
to
5d15571
Compare
|
Could you sign CONTRIBUTORS.txt please unless you already have and I missed it. |
|
Thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headers such as
X-Forwarded-For,X-Forwarded-HostandForwardedcan contain more values than are actually trusted, leading to the possibility that the downstream application could interpret those headers differently to waitress.This change rewrites the trusted headers so that they only contain the values from the trusted proxies.
Relates to issue #451