Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PyO3 0.23 #455

Open
ngoldbaum opened this issue Oct 9, 2024 · 4 comments
Open

Support for PyO3 0.23 #455

ngoldbaum opened this issue Oct 9, 2024 · 4 comments

Comments

@ngoldbaum
Copy link

I'm looking at using rust-numpy with the free-threaded Python build and it looks like the first blocker is 0.23 support. The error I hit out of the box after pointing the cargo.toml at my local copy of PyO3 is:

error: failed to select a version for `pyo3`.
    ... required by package `numpy v0.21.0 (/Users/goldbaum/Documents/rust-numpy)`
versions that meet the requirements `*` are: 0.23.0-dev

the package `numpy` depends on `pyo3`, with features: `gil-refs` but `pyo3` does not have these features.

So it looks like the first step is removing the uses of the gil-refs feature and fully transitioning to the bound reference API.

@davidhewitt
Copy link
Member

Yep, looks like @Icxolu has made great progress in #457 (🙏). We wouldn't merge that until we actually release 0.23 upstream, however.

@kylebarron
Copy link

Now that #457 has been merged, would we be able to get an 0.23 release of numpy?

@davidhewitt
Copy link
Member

I hope to prep a release branch tonight :)

@davidhewitt
Copy link
Member

#473 is in the oven :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants