Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor repetitions to a separate datastructure #126

Open
mstechly opened this issue Nov 7, 2024 · 0 comments
Open

Refactor repetitions to a separate datastructure #126

mstechly opened this issue Nov 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@mstechly
Copy link
Contributor

mstechly commented Nov 7, 2024

As @dexter2206 mentioned in PsiQ/bartiq#136 (review):

After reviewing this and the QREF's counterpart of this PR I'm more and more convinced that it would be better if we had a separate class representing "loop" or a "routine with repetitions" (or at least if we had it in Bartiq). This is because a lot of the logic we perform for validation and dispatching (with ifs) could be neatly hidden. For instance, we verify if routine with repetition has one child - but we could have an object that HAS to have one child (which would be validated by Pydantic). (...)

We should evaluate whether we want to introduce such a change in QREF natively or just in Bartiq.

@mstechly mstechly added the enhancement New feature or request label Nov 7, 2024
@mstechly mstechly changed the title Refactor repetitions Refactor repetitions to a separate datastructure Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant