feat: allow to pass --ckpt.resume and start from scratch if no ckpt f… #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackmin801
approved these changes
Aug 23, 2024
samsja
force-pushed
the
feat-auto-resume
branch
from
828ed3e
to
91463ce
Compare
yes, it works! It works even too much, even if I start a different run (ex change a hp) it will resuse the old run. I just changed the behavior to only trigger wandb auto resume if we are restarting from a ckpt. It might still be a problem if I switch from one run to another when I restart from ckpt but different run from the one before. But I think we can live with that for now. just being careful |
samsja
force-pushed
the
feat-auto-resume
branch
from
91463ce
to
383df34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iles are present.
This allow to pass the same command for starting from scratch and for auto resuming. Making it easier to handle elastic jobs