Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix torch compile log act #23

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Fix torch compile log act #23

merged 4 commits into from
Aug 21, 2024

Conversation

samsja
Copy link
Collaborator

@samsja samsja commented Aug 20, 2024 •
edited
Loading

what this pr do

  • handle torch compile and remove origin_param from name
  • make logging dict persistent across all grad acc steps

@samsja samsja requested a review from Jackmin801 August 20, 2024 20:20
Jackmin801
Jackmin801 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@Jackmin801 Jackmin801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm :)

@samsja samsja merged commit 8ce08c0 into main Aug 21, 2024
2 checks passed
samsja added a commit that referenced this pull request Aug 21, 2024
@samsja
fix torch compile log act (#23)
d0d6f29 
* fix renaming logic for key

* fix stuff

* fix exploding norm

* remove print
samsja added a commit that referenced this pull request Aug 22, 2024
@samsja
fix torch compile log act (#23)
f6748dd 
* fix renaming logic for key

* fix stuff

* fix exploding norm

* remove print
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jackmin801 Jackmin801 Jackmin801 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsja @Jackmin801