Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor ckpt and add topk save #21

Merged
merged 4 commits into from
Aug 19, 2024
Merged

refactor ckpt and add topk save #21

merged 4 commits into from
Aug 19, 2024

Conversation

samsja
Copy link
Collaborator

@samsja samsja commented Aug 19, 2024

What this pr do:

  • refactor ckpt args/config into its own nested BaseConfig
  • allow to pass resume as a boolean that will pick the latest available ckpt
  • allow only to keep topk ckpt to keep reduce space in file system / s3 / gcp storage
  • refactor and move ckpt related code to ckpt_utils.y

@samsja samsja marked this pull request as ready for review August 19, 2024 09:39
@samsja samsja requested a review from Jackmin801 August 19, 2024 09:39
Jackmin801
Jackmin801 requested changes Aug 19, 2024
View reviewed changes
Copy link
Member

@Jackmin801 Jackmin801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! makes the checkpointing stuff more modular and the new resume logic should make it that one doesnt need to change the launch string.

added a comment on a change that looks a bit weird to me

open_diloco/train_fsdp.py Outdated Show resolved Hide resolved
@samsja samsja requested a review from Jackmin801 August 19, 2024 13:23
Jackmin801
Jackmin801 approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@Jackmin801 Jackmin801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm

@samsja samsja merged commit 8b7b6a8 into main Aug 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jackmin801 Jackmin801 Jackmin801 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsja @Jackmin801