This repository has been archived by the owner on Mar 17, 2020. It is now read-only.
Fix Mixed content problem on shops with SSL #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When SSL is activated on all pages oh the shop, ajax GET request are being redirected. This happpens on default FrontController.php on line 785. In this method:
/**
* Redirects to correct protocol if settings and request methods don't match.
*/
protected function sslRedirection()
{
// If we call a SSL controller without SSL or a non SSL controller with SSL, we redirect with the right protocol
if (Configuration::get('PS_SSL_ENABLED') && $_SERVER['REQUEST_METHOD'] != 'POST' && $this->ssl != Tools::usingSecureMode()) {
$this->context->cookie->disallowWriting();
header('HTTP/1.1 301 Moved Permanently');
header('Cache-Control: no-cache');
if ($this->ssl) {
header('Location: '.Tools::getShopDomainSsl(true).$_SERVER['REQUEST_URI']);
} else {
header('Location: '.Tools::getShopDomain(true).$_SERVER['REQUEST_URI']);
}
exit();
}
}
The condition is true and there is a HTTP redirection.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SSL is activated on all pages of the shop, ajax GET requests are being redirected.
This happpens on default FrontController.php on line 785 (Prestashop 1.6), in the method:
The condition is true and there is an HTTP redirection, what cause the mixed content problem on new browsers.
Can anyone reproduce this problem? Could be happening on other ajax GET requests.