Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated texture interpolation ignores alpha channel during transition from/to transparent pixels #8

Closed
Scarlaid opened this issue May 1, 2022 · 3 comments
Labels
status: accepted This issue can be reproduced, or this feature may be implemented. type: Minecraft bug fix This issue requests a bug in Minecraft to be fixed.
Milestone

Comments

@Scarlaid
Copy link

Scarlaid commented May 1, 2022

Issue explanation

If an animated texture that uses texture interpolation ({"interpolate": true} in the .mcmeta file) contains transparent pixels, the following behaviors can be observed:

  • When fading TO transparent pixels, i.e. having a pixel that starts opaque and becomes transparent in the next frame, during the interpolation they will fade to whatever the RGB values for the pixels are, ignoring the alpha channel (the game just behaves as if the pixel was fully opaque). Once the transition is over, those pixels instantly change from that color to transparent, which creates a very jarring effect.
  • When fading FROM transparent pixels, i.e. having a pixel that starts transparent and becomes opaque in the next frame, they'll appear completely transparent until the transition is over. Once it is over, the correct color will, again, appear all of a sudden.

Mojira issue link

https://bugs.mojang.com/browse/MC-144761

Other

Said pretty much everything about a 2 line dif
Still affects modern Minecraft versions till 1.18
image

I was surprised, tested myself as following the reproduction in the issue itself, and yes, this still isn't fixed in 1.18.2
This mod claimed to fix the issue, but it only works for 1.16.1 + crashed with Sodium/Continuity

@Scarlaid Scarlaid added status: awaiting triage This issue or feature request still needs to be confirmed. type: Minecraft bug fix This issue requests a bug in Minecraft to be fixed. labels May 1, 2022
@NoahvdAa NoahvdAa added status: accepted This issue can be reproduced, or this feature may be implemented. and removed status: awaiting triage This issue or feature request still needs to be confirmed. labels May 1, 2022
NoahvdAa added a commit that referenced this issue May 2, 2022
@NoahvdAa NoahvdAa added this to the Next release (1.1.1+) milestone May 2, 2022
@NoahvdAa
Copy link
Member

NoahvdAa commented May 2, 2022

This has been fixed in 6d6d368 and will be included in the next release :)

@NoahvdAa NoahvdAa closed this as completed May 2, 2022
@Scarlaid
Copy link
Author

Scarlaid commented May 3, 2022

any chance fixing #4 and #5 or you already did?
I'm just curious to ask

@NoahvdAa
Copy link
Member

NoahvdAa commented May 3, 2022

These haven't been fixed, I have not had time for them yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted This issue can be reproduced, or this feature may be implemented. type: Minecraft bug fix This issue requests a bug in Minecraft to be fixed.
Projects
None yet
Development

No branches or pull requests

2 participants