Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHEBI roles #98

Open
marieALaporte opened this issue Jun 6, 2017 · 5 comments
Open

CHEBI roles #98

marieALaporte opened this issue Jun 6, 2017 · 5 comments

Comments

@marieALaporte
Copy link
Contributor

I am checking the exposure-chebi.tsv file for the patterns.

Should we make a separate file for the eo/peco classes that map to a chebi role? and have separate yaml file for those with a nested definition or something like that?

@austinmeier @cmungall @cooperl09

@cmungall
Copy link
Member

cmungall commented Jun 6, 2017 via email

@marieALaporte
Copy link
Contributor Author

@cmungall shall we make a DP for them ?
Something like for the fertilizer:

'plant treatment' 
  and 'has exposure stimulus'
    some ('chemical entity' and 'has role' some 'fertilizer')

@cmungall
Copy link
Member

cmungall commented Jun 8, 2017

Perfect. In GO we precoordinated classes like this, as we couldn't handle the nesting. Here it's OK (but may be a bit before we can handle in AmiGO).

Be careful with the nutrient branch of CHEBI, it's human-specific. You may get odd inferences for micronutrient.

I think we need our own mini plant nutrient role ontology (or chemical-with-nutrient-role ontology)

@cmungall
Copy link
Member

was this fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants