Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the whole request listening/handling chain #72

Open
jvyden opened this issue Nov 26, 2023 · 0 comments
Open

Rewrite the whole request listening/handling chain #72

jvyden opened this issue Nov 26, 2023 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@jvyden
Copy link
Member

jvyden commented Nov 26, 2023

The entire chain of events from invoking the Listener to calling the main middleware is very confusing, even for someone like me who wrote the whole thing and should understand it. It was very hard to debug the fix for 36990eb (and the problem is still unknown...)

We need to reconsider how this flow should work to make it easier to parse. Additionally, it uses a lot of asynchronous calls which causes many headaches, so it should be synchronous like the rest of Bunkum.

The way it's currently implemented, worker threads don't actually mean anything since we just create new tasks on the task factory to handle each request, which is stupid.

@jvyden jvyden added bug Something isn't working enhancement New feature or request labels Nov 26, 2023
@jvyden jvyden self-assigned this Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant