-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple cookie secrets #391
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guyeisenbach
force-pushed
the
feature/multiple-cookies
branch
6 times, most recently
from
September 11, 2024 09:07
6e0cc99
to
bb53c2f
Compare
guyeisenbach
force-pushed
the
feature/multiple-cookies
branch
from
September 11, 2024 09:15
bb53c2f
to
a819371
Compare
chen-zimmer-px
requested changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment
src/main/java/com/perimeterx/internals/cookie/cookieparsers/HeaderParser.java
Show resolved
Hide resolved
guyeisenbach
force-pushed
the
feature/multiple-cookies
branch
from
September 12, 2024 09:06
98ad8eb
to
84986cc
Compare
src/main/java/com/perimeterx/internals/cookie/AbstractPXCookie.java
Outdated
Show resolved
Hide resolved
chen-zimmer-px
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.