Supporting Slingshot #20
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR to keep the changes neccesary for supporting Slingshot in the Experiment Automation.
The PR contains several changes that impact how Experiment Automation worked in the past, hence, I don't advise merging it. It is a draft PR to keep track of the integration work neccessary for Slingshot.
One feature which was missing before was the ability to specify a set of long values for the closed workload population variation. Now this is possible with an additional SetLongValueProvider, where the initial SetValueProvider is implemented as a double provider strategy. One could find better alternatives how to add this support.
Current experiment automation is not completely independent from SimuLizar, it has implicit knowledge on how/where Simulizar stores the models, or where architectural templates keep the models and so on and so forth. In this version, I assume a more simplistic case where the VaryJob modifies the models in the single partition which Slingshot uses, and the tool-specific Slingshot configuration, copies the varied models to a temp location, and copies them back to the default partition after the simulation. This way the copying in the tool-specific job, after the simulation reverts back the initial varied model to the default partition. The next VaryJob can then modify the model accordingly to the next factor. This copying is neccessary to remove all the effects of simulating SPD.