-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new target Pixhawk5X #215
base: main
Are you sure you want to change the base?
Conversation
hw_config.h
Outdated
# define BOOTLOADER_DELAY 5000 | ||
# define INTERFACE_USB 1 | ||
# define INTERFACE_USART 1 | ||
# define USBDEVICESTRING "Pixhawk5X.x" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the VID/PID has ripple effects on the the Firmware and QGC. On the Firmware the board will need it's own board support. If the USBDEVICESTRING does not contain PX4 BL it will have issues.
See
Lines 11 to 18 in d0c2b65
/**************************************************************************** | |
* 10-8--2016: | |
* To simplify the ripple effect on the tools, we will be using | |
* /dev/serial/by-id/<asterisk>PX4<asterisk> to locate PX4 devices. Therefore | |
* moving forward all Bootloaders must contain the prefix "PX4 BL " | |
* in the USBDEVICESTRING | |
* This Change will be made in an upcoming BL release | |
****************************************************************************/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davids5
Thanks for the reminder. I have add the prefix "PX4 BL"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are effect on the Firmware and QCG if this change is made.
@davids5 The bootloader on Pixhawk5X currently shows this information, with the USBMFGSTRING as "Auterion" We feel like it is inaccurate so we want to change it to. May you please let me know if this is possible? What kind of firmware & QGC changes needs to be made? Is there other alternative? |
@mrpollo - Would you please enumerate all the changes you unstreamed to QGC for V5X. FYI: @LorenzMeier a board_id (BOARD_TYPE in bootloader) 51 (0x33 hex) is used to select the firmware. TARGET_HW_PX4_FMU_V5X and TARGET_HW_PIXHAWK5X would have the same id therefore the FW would be px4_fmuv-5x and it has build time setting for the CDCACM values of VID/PID/MFG (A limitation of NuttX) so it will report with the "Auterion" set. a) To resolve this we would need dynamic USB CDCACM based on the REV/VER |
@davids5 its a straightforward change in QGC, see this PR mavlink/qgroundcontrol#9816 |
Pixhawk5X is produced by holybro. It is full base on Pixhawk FMUV5X standards.
This new bootloader has Holybro usb pid and manufacture string.