Hai 750

[Dutervil]

Please, take a look in this PR Please @mogoodrich , @dmdesimone

[mogoodrich]

So I made two changes (removing the one line and adding another) and got it close to working... it works, but you have to manually click on the last address field to get things to "jump" ahead.

Here's the long-winded description, hope this helps:

This functionality was originally building using a "one-question-per-screen" navigator that was designed years ago (like in 2013) that was written before jquery (no mind more advanced tools).

You can find the code here:
https://github.com/openmrs/openmrs-module-uicommons/tree/master/omod/src/main/webapp/resources/scripts/navigator

Basically, it parses the HTML to come up build up a kind of section/question/field module and then allows the users to navigate through it using the keyboard and provides functionality to jump from one question to the next.

You can see some of the API methods it provides here:

https://github.com/openmrs/openmrs-module-uicommons/blob/master/omod/src/main/webapp/resources/scripts/navigator/navigator.js

In order to debug what was happening, I looked at what was happening in the personAddressWithHierachy.gsp, and specifically how it populated the fields from the "quick entry" shortcut. It was there that I noticed this line:

https://github.com/openmrs/openmrs-module-registrationapp/blob/master/omod/src/main/webapp/resources/scripts/field/personAddressWithHierarchy.js#L75

which lead to the line I suggested in the PR.

It "sort-of" works now, though the users has to still manually click through all the fields.

I suspect we can make it better by further understanding how personAddressWithHierarchy.js works and making some further changes... can you take a look and let me know what you think, @Dutervil ? Feel free to ask any further questions!

[mogoodrich]

Can you try removing this line? I think disabling the inputs result it in not getting saved?

[Dutervil]

Do you mean @mogoodrich line 434?

[mogoodrich]

Yeah, exactly @Dutervil

[mogoodrich]

I added a line: " jq(this).data('legalValues', [ valuesArray[index] ])" which I think needs to happen for the entry to be considered "valid" (see my overall comments).

[Dutervil]

I added focused class to the autocomplete when the checkbox is checked. I hoped that would help. it stil does not save in DB

[Dutervil]

Thank you!

…

On Fri, Aug 11, 2023, 3:26 PM Mark Goodrich ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In configuration/pih/scripts/global/zl.js <#254 (comment)> : > + + //Creating a label to show the checkbox title + const labelElement = jq("<label>", { + for: "question_address", + text: message + }); + + //creating a break line to push other elements a litle bit down + const brElement = $("<br>"); + divElement.prepend(checkboxElement, labelElement, brElement); + + // checkbox event occurs here + jq('#question_address').on('change', function() { + if (this.checked) { + //disable other input if the want to use the patient address as contact address + isInputDisabled(true); Yeah, exactly @Dutervil <https://github.com/Dutervil> — Reply to this email directly, view it on GitHub <#254 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKUL3DFJIZVEJUVPT4Q2PY3XU2BPTANCNFSM6AAAAAA3L2HXII> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Dutervil]

Hi @mogoodrich . I remoced the line you said. I use this line " jq(this).data('legalValues', [ valuesArray[index] ])" that you provide. it does not work. I leave it as previous, always no adress info saved in DB. So i looked at this, but I do not see something from it that can help in that case. So what do you suggest @mogoodrich ? I would like to finish this ticket today. it lasted too long. https://github.com/openmrs/openmrs-module-registrationapp/blob/master/omod/src/main/webapp/resources/scripts/field/personAddressWithHierarchy.js#L75

[mogoodrich]

This actually worked for me @Dutervil ! I checked out your latest changes and removed the comment from line 462.

Here's the screenshots I'm seeing

Here's the initial page:

Then when I click on the link:

I then have to manually click down to the last field... this was the one thing I couldn't get working properly:

After saving, when I go to the registration summary I see the contact person address:

Note if you are looking in the database, this information (and the place of birth) is stored as a obs on the registration table:

[Dutervil]

This is good. I will try to make the last field clicked by itself to see if this will work as expected @mogoodrich

[mogoodrich]

Thanks @Dutervil ... let me know if this is ready for review.

[louidorjp]

Hi @mogoodrich and @Dutervil , I've made a few modifications. It seems to be working well - you can test it now.

[mogoodrich]

thanks @Dutervil @louidorjp , LGTM!