Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last 3.x minor | Hard deprecate old-style setting of array properties #693

Open
jrfnl opened this issue Nov 17, 2024 · 0 comments
Open

Last 3.x minor | Hard deprecate old-style setting of array properties #693

jrfnl opened this issue Nov 17, 2024 · 0 comments

Comments

@jrfnl
Copy link
Member

jrfnl commented Nov 17, 2024

PHPCS 3.3.0 (June 2018) introduced a new XML format to pass custom array properties to sniffs.

Support for the old-style comma-separate string format for passing array values was deprecated in PHPCS 3.3.0 and support for the old format will be removed in PHPCS 4.0 as discussed in squizlabs/PHP_CodeSniffer#1665

I think it would be prudent to add a deprecation notice in one of the last 3.x minors to bring this to the attention of ruleset maintainers who haven't updated their ruleset yet.

Refs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant