Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-compose v1 is deprecated #281

Closed
tpluscode opened this issue Aug 13, 2024 · 4 comments · Fixed by #286
Closed

docker-compose v1 is deprecated #281

tpluscode opened this issue Aug 13, 2024 · 4 comments · Fixed by #286
Labels
up for grabs

Comments

@tpluscode
Copy link
Contributor

tpluscode commented Aug 13, 2024 •
edited
Loading

I see issues and PRs #276 #277 #278 but I question whether that effor is really necessary in the first place

docker-compose (v1) has been deprecated since June 2023 https://docs.docker.com/compose/migrate/

Recently, GitHub workflow runners do not come with docker-compose any more, resulting in error Error: spawn docker-compose ENOENT

I think that rather than trying to patch an already complex build setup, v1 should be dropped a v2 should be the only export from this package...
@Steveb-p
Copy link
Contributor

A this point in time, yeah. Guess we could release a major version just to be strict about it.

@AlexZeitler
Copy link
Contributor

Makes sense

@AlexZeitler
Copy link
Contributor

Since I don't have much time in the next few weeks (and honestly haven't done anything with Node.js for over a year - except maintaining this library), I tagged it with up for grabs.

@tpluscode
Copy link
Contributor Author

Happy to send a PR

@tpluscode tpluscode mentioned this issue Aug 15, 2024
Closed
@AlexZeitler AlexZeitler mentioned this issue Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
up for grabs
Projects
None yet
Milestone
No milestone
3 participants
@AlexZeitler @tpluscode @Steveb-p