Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] A fresh clone tries to download JDKs for every platform #6434

Open
io7m opened this issue Dec 16, 2020 · 5 comments
Open

[Build] A fresh clone tries to download JDKs for every platform #6434

io7m opened this issue Dec 16, 2020 · 5 comments
Labels

Comments

@io7m
Copy link

io7m commented Dec 16, 2020

Describe the bug
I want to build the sources on Linux. I clone the project, and then execute ./gradle tasks to see which build tasks are available. This results in the build script immediately trying to download at least one large JDK for multiple platforms.

To Reproduce
Steps to reproduce the behavior:

  1. git clone https://github.com/PCGen/pcgen
  2. cd pcgen
  3. ./gradlew tasks
  4. Note that you're downloading many JDKs, each around ~200mb in size.

Expected behavior
Let me use the JDK I already have. 😄
I understand why you want to download JDKs for each platform; I do the same myself when producing application distributions. I think you may be executing the download tasks too eagerly, however...

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):


$ java -version
openjdk version "14.0.2" 2020-07-14
OpenJDK Runtime Environment (build 14.0.2+12)
OpenJDK 64-Bit Server VM (build 14.0.2+12, mixed mode)
@io7m io7m added the bug label Dec 16, 2020
@LegacyKing
Copy link
Member

Sounds like we need to move some things around.

@Vest
Copy link
Contributor

Vest commented Nov 19, 2022

I can contribute into this issue, that today (in 2022) the file build.gradle tries to load JDK that doesn't even exist:

* What went wrong:
A problem occurred evaluating root project 'pcgen'.
> Failed to calculate the value of task ':compileJava' property 'javaCompiler'.
   > Unable to download toolchain matching these requirements: {languageVersion=16, vendor=any, implementation=vendor-specific}
      > Unable to download toolchain. This might indicate that the combination (version, architecture, release/early access, ...) for the requested JDK is not available.
         > Could not read 'https://api.adoptopenjdk.net/v3/binary/latest/16/ga/mac/aarch64/jdk/hotspot/normal/adoptopenjdk' as it does not exist.

I don't know, if we are ready for Java 17 (see PR #6727), but I can try to prepare a PR-fix for this issue.

@karianna
Copy link
Contributor

#6727 is in theory sorting this out

@Vest
Copy link
Contributor

Vest commented Nov 22, 2022

@karianna do you know, if your PR will be ever approved?

@karianna
Copy link
Contributor

:-D - A very fair question. I'm still battling the Gradle build here locally as it doesn't always place the JavaFX module components in the target uber JAR binaries. If your'e a Gradle expert then I'd love to pair on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants