-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Card-builder documentation #16
Comments
Hello, Thank you for checking out our resources and your mindful feedback! I see two issues raised that need addressing:
Unless you have any specific follow-ups, I'll create a separate issue for that sample JS file and will close this issue once I update the README to include the full list of dependencies. |
Just a comment, I don't think updating the README.md with a full list of dependencies is a good idea because then you (and your maintainers) will have a duplication of truth (two lists of dependencies that you'll have to keep in sync, one in package.json and one in README.md). Rather than that extra complexity, the dependencies should simply be maintained via the Do you mind if I create a corresponding pull request? As for the last part, creating a template md file and html that runs the script would be great. Please link the new issue here and I'll share a possible solution. Thanks. |
That's an excellent point! Yes, feel free to create a corresponding pull request. I'll review it. I also created #17. Feel free to share your possible solution there. Again, you have my gratitude. |
Hi group,
Thanks for developing this tool!
To make this potential wide-audience tool more accessible to all, it would be great to see the card-builder documentation improved, specifically the local development section. From my perspective (I very rarely work with Javascript), I see the main challenges as follows:
npm run build
does not seem to work out of the box (I had to install esbuild and sass)The text was updated successfully, but these errors were encountered: