chore(release): Merge v8.2.0-alpha.4 into edge #16981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…16884) Closes RQA-3583 Currently, the app inspects an errorType on a failed drop tip command to determine whether to throw the special case "home the gantry" error modal. Recently, the error type changed for failed update estimator commands, so the special modal was broken. Instead of special-casing the errorType for failed estimator commands, let's just assume that any failed estimator command is caused by an unknown position error and pop the special modal. Note that this also handles any error in the same manner with a "MustHomeError" errorType, too.
# Overview Known issue for downgrading below 8.2 with a plate reader attached. ## Test Plan and Hands on Testing Check in next alpha. ## Changelog Single bullet in API release notes. ## Review requests - Does this capture the issue properly? Is there a related app-side issue? - Do we need to mention the problem of downgrading a robot _on the same network_ as a plate reader? ## Risk assessment nil
# Overview Prettier (or whatever runs in our JS lint action) demands a newline after a markdown header. OK. ## Test Plan and Hands on Testing Pass automated tests plz. ## Changelog `\n` ## Review requests Forgive this shameful and time-wasting PR. ## Risk assessment none
…id_auto_seal_lid to release (#16903) Covers RABR-669 Adds compatibility between `biorad_96_wellplate_200ul_pcr` and `opentrons_tough_pcr_auto_sealing_lid` with stacking z offset
Closes RABR-672
Closes RQA-3645 Recent gripper firmware changes add new degrees of G axis "home" state, and this ultimately causes the unsafe/ungripLabware command to fail, since a successful completion of the ungrip does not set the HOME flag. Because we ultimately want to ungrip the labware AND home the gripper G axis, let's use a parameterized home command instead.
* fix(components): fix unit text wrap-issue
…losed (#16941) Covers RABR-674 Raises an error during analysis when the plate reader lid is not closed and a read is attempted.
…e recovery policies during a run (#16950) Closes RQA-3670 We need to support the client ignoring several different classes of errors in a single run, which means the app needs to know the current recovery policy and be able to modify. This PR adds the necessary infrastructure to support that. Co-authored-by: Max Marrone <max@opentrons.com>
Conflicts: api/src/opentrons/protocol_engine/commands/absorbance_reader/read.py: Conflict in error message wording between PR #16941 in release and PR #16920 in edge. I took the one in release because the one in edge was an outdated cherry pick. app/src/organisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/RunHeaderModalContainer/hooks/useRunHeaderDropTip.ts: Just import statements. app/src/organisms/DropTipWizardFlows/hooks/useTipAttachmentStatus/getPipettesWithTipAttached.ts: Release removed `cursor: null` and `includeFixitCommands: null` from some network requests, leaving those fields unspecified instead (PR ##16893). Edge deleted this whole file in favor of a different one (PR #16904). I removed `cursor: null` from the new file; `includeFixitCommands: null` was already removed.
mjhuff
approved these changes
Nov 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #16981 +/- ##
==========================================
+ Coverage 73.90% 79.21% +5.30%
==========================================
Files 43 120 +77
Lines 3231 4517 +1286
==========================================
+ Hits 2388 3578 +1190
- Misses 843 939 +96
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Merge the latest release alpha into
edge.Test Plan and Hands on Testing
None.
Changelog
Conflicts:
api/src/opentrons/protocol_engine/commands/absorbance_reader/read.py:Conflict in error message wording between PR #16941 in release and PR #16920 in edge. I took the one in release because the one in edge was an outdated cherry pick.
app/src/organisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/RunHeaderModalContainer/hooks/useRunHeaderDropTip.ts:Just import statements.
app/src/organisms/DropTipWizardFlows/hooks/useTipAttachmentStatus/getPipettesWithTipAttached.ts:Release (PR #16893) removed
cursor: nullandincludeFixitCommands: nullfrom some network requests, leaving those fields unspecified instead. Edge (PR #16904) deleted this whole file in favor of a different one. I removedcursor: nullfrom the new file;includeFixitCommands: nullwas already removed.Review requests
Risk assessment
Medium risk. There might be more stuff like the
cursor: nullthing lurking about.