Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android example code not releasing the SurfaceViewRenderer videoView in leaveSession() #167

Open
matkey opened this issue Oct 28, 2021 · 2 comments

Comments

@matkey
Copy link

matkey commented Oct 28, 2021

Getting lots of the below log lines from webrtc when a call is ended. Looks like something isnt being tidied up as it should be

2021-10-28 17:17:16.022 23656-24679/XXXXX I/org.webrtc.Logging: EglRenderer: local_gl_surface_viewXDuration: 4011 ms. Frames received: 0. Dropped: 0. Rendered: 0. Render fps: .0. Average render time: NA. Average swapBuffer time: NA.
2021-10-28 17:17:20.031 23656-24679/XXXXX I/org.webrtc.Logging: EglRenderer: local_gl_surface_viewXDuration: 4008 ms. Frames received: 0. Dropped: 0. Rendered: 0. Render fps: .0. Average render time: NA. Average swapBuffer time: NA.
2021-10-28 17:17:24.038 23656-24679/XXXXX I/org.webrtc.Logging: EglRenderer: local_gl_surface_viewXDuration: 4007 ms. Frames received: 0. Dropped: 0. Rendered: 0. Render fps: .0. Average render time: NA. Average swapBuffer time: NA.
2021-10-28 17:17:28.045 23656-24679/XXXXX I/org.webrtc.Logging: EglRenderer: local_gl_surface_viewXDuration: 4003 ms. Frames received: 0. Dropped: 0. Rendered: 0. Render fps: .0. Average render time: NA. Average swapBuffer time: NA.
2021-10-28 17:17:32.053 23656-24679/XXXXX I/org.webrtc.Logging: EglRenderer: local_gl_surface_viewXDuration: 4011 ms. Frames received: 0. Dropped: 0. Rendered: 0. Render fps: .0. Average render time: NA. Average swapBuffer time: NA.

@matkey
Copy link
Author

matkey commented Oct 28, 2021

Fix is adding the below

for (RemoteParticipant remoteParticipant : remoteParticipants.values())
{
    if (remoteParticipant.getPeerConnection() != null) {
        remoteParticipant.getPeerConnection().close();
    }
    views_container.removeView(remoteParticipant.getView());

    **remoteParticipant.getVideoView().release();**
}

@micaelgallego
Copy link
Member

@CSantosM can you take a look please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants