Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes when reading OTIO file with SerializableCollection #23

Open
jminor opened this issue Oct 5, 2023 · 1 comment
Open

Crashes when reading OTIO file with SerializableCollection #23

jminor opened this issue Oct 5, 2023 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jminor
Copy link
Member

jminor commented Oct 5, 2023

If Raven is given an OTIO file with a top-level object that isn't a Timeline, it crashes. The most common case of this is an OTIO file with a SerializableCollection containing multiple timelines.

At the very least, it should give the user a helpful error message instead of crashing.

Even better it could present each different type of OTIO object in a reasonable manner. For SerializableCollection, maybe tabs for each item. For other types like MediaReference, Clip, etc. it could just show the JSON and Inspector without the timeline view.

@jminor jminor added the help wanted Extra attention is needed label Jan 18, 2024
@jminor
Copy link
Member Author

jminor commented Jan 18, 2024

Here's an example of a case where it would be useful to view a SerializableCollection: AcademySoftwareFoundation/OpenTimelineIO#1687

@reinecke reinecke added the good first issue Good for newcomers label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants