Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend linters in precommit hook #584

Open
nesnoj opened this issue Oct 11, 2024 · 2 comments
Open

Extend linters in precommit hook #584

nesnoj opened this issue Oct 11, 2024 · 2 comments
Assignees
@nesnoj
Labels
🔽 low prio Low priority issue 🚀 feature New feature or request

Comments

@nesnoj
Copy link
Collaborator

nesnoj commented Oct 11, 2024

Currently in the precommit hooks only black is applied which is insufficient.
@nesnoj nesnoj added 🚀 feature New feature or request 🔽 low prio Low priority issue labels Oct 11, 2024
@FlorianK13
Copy link
Member

Which other hooks do you have in mind?

@nesnoj
Copy link
Collaborator Author

nesnoj commented Oct 15, 2024

I thought about isort, flake8, pylint and hooks from https://github.com/pre-commit/pre-commit-hooks as black does not cover everything.

Examples from other projects:
django-mapengine
eGon-data

@nesnoj nesnoj self-assigned this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nesnoj nesnoj

Labels
🔽 low prio Low priority issue 🚀 feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nesnoj @FlorianK13