Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prior bulk zip files are deleted on download #564

Open
nesnoj opened this issue Sep 17, 2024 · 2 comments
Open

Prior bulk zip files are deleted on download #564

nesnoj opened this issue Sep 17, 2024 · 2 comments
Assignees
Labels
🔽 low prio Low priority issue 🐛 bug Something isn't working

Comments

@nesnoj
Copy link
Collaborator

nesnoj commented Sep 17, 2024

Alle files in the xml dir are cleared when a download is triggered. This is annoying when users want to keep old releases.
The xml dir needs to be created though, but this is redundantly done before the download starts.

Is there a reason why it is done this way - any objections against removing this behaviour? @FlorianK13

@nesnoj nesnoj added the 🐛 bug Something isn't working label Sep 17, 2024
@nesnoj nesnoj self-assigned this Sep 17, 2024
@FlorianK13
Copy link
Member

Yes, we did not want to fill up storage from users who are not aware that every download is saved forever. I would argue for keeping this as default behavior, but we can add a parameter keep_old_downloads to keep the existing zipped files?

@nesnoj nesnoj added the 🔽 low prio Low priority issue label Sep 18, 2024
@nesnoj
Copy link
Collaborator Author

nesnoj commented Sep 18, 2024

That's reasonable! However, a quiet deletion is annoying and a confirmation was helpful.
And a param for keeping old versions sounds good to me.
Thx for the quick feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔽 low prio Low priority issue 🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants