Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate features from open-mastr #487

Open
1 of 2 tasks
FlorianK13 opened this issue Feb 19, 2024 · 3 comments
Open
1 of 2 tasks

Deprecate features from open-mastr #487

FlorianK13 opened this issue Feb 19, 2024 · 3 comments
Assignees

Comments

@FlorianK13
Copy link
Member

FlorianK13 commented Feb 19, 2024

Discussion

Users that are affected by this deprecation can leave their comments in this issue.


Should we think about adding a deprecation warning to the soap API features .download and .mirror? We could print the message that those features will not be maintained in the future. If people still use them, they should tell us in an Issue.

Explanation

Both functions are used to download large amount of data via the SOAP API. Since BNetzA has a bulk download for quite some time now, I don't think that we need to maintain this feature anymore.

@chrwm What do you think?

Todos

  • State very prominently in documentation that these features are deprecated, maybe even in the sidebar
  • Delete tests for the deprecated features
@FlorianK13
Copy link
Member Author

Currently mastr mirror tests are causing problems, so we should also delete those tests and rather focus our (limited) time on fixing and maintaining other parts of the code.

FlorianK13 added a commit that referenced this issue Mar 8, 2024
FlorianK13 added a commit that referenced this issue Mar 8, 2024
Additionally, black did reformatting.
FlorianK13 added a commit that referenced this issue Mar 8, 2024
Not related to this feature, but had to be done anyway.
FlorianK13 added a commit that referenced this issue Mar 19, 2024
@chrwm chrwm mentioned this issue Apr 10, 2024
@FlorianK13
Copy link
Member Author

This is merged on develop and will be released soon.

@nesnoj
Copy link
Collaborator

nesnoj commented Aug 27, 2024

Leave open for user feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants