[PATCH v2] api: pktio: lso: improve the specification of IPv4 and TCP LSO #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
Modify certain details of IP and TCP LSO, specify missing details, add restrictions and clarify the API in general. - Specify that the DF flag of the IPv4 header is to be preserved as it was in the original packet and not cleared as the current spec says. Disallow IPv4 LSO for packets that contain IPv4 options that may not simply be copied to all fragments. Describe IPv4 ID generation in more detail. - Specify IPv6 fragmentation in more detail. Specify that the payload offset must point to the offset in which the fragment header is to be inserted, allowing flexible handling of different types of extension headers. Add restrictions on for what kind of packets IPv6 fragmentation can be requested. - Specify that IPv4 or IPv6 LSO is not permitted for packets that are already fragments or for which L4 checksum offload is requested. - Specify TCP segmentation in more detail and add restriction on what kind of TCP control bits and options may be present in packets for which the offload is attempted. - Clarify how L3 offset, L4 offset and payload offset must be set. Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com>
JannePeltonen
force-pushed
the
api-lso-impr
branch
from
67365bd
to
0e71679
Compare
odpbuild
changed the title
|
v2: Revamped the text quite a bit, adding at the same time multiple restrictions regarding what kind of packets LSO can be requested for. Added also descriptions for IPv6 LSO and TCP_IPV6 LSO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the DF flag handling in TCP segmentation offload and improve the description in general:
Specify that the DF flag of the IP header is to be preserved as it was in the original packet and not cleared as the current spec says.
Specify that TCP segmentation should be done in a way that complies with the TCP standard, without going into details. This entails proper handling of various TCP header flags and TCP options.
Specify that unique ID values are generated for non-atomic datagrams and leave it unspecified how the ID value is updated for atomic datagrams (packets which are not fragments and have the DF flag set). Suggest that an application should avoid sending packets with ID values that may lead to overlapping IDs after segmentation.
Improve the description of IPv4 fragmentation offload. This does not change the meaning of the specification but makes it clear that the DF flag is not affected by LSO and that IP option fields are processed as specified in the standard.