[PATCH v2] api: queue: clarify odp_queue_param_t default value specification #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
psavol
approved these changes
Oct 16, 2023
PavanNikhilesh
approved these changes
Oct 17, 2023
Move default queue type specification from odp_queue_create() to odp_queue_param_t to make it conform with the other parameters. Also, explicitly state that queue size default value is zero. This was already tested by the validation test. Signed-off-by: Matias Elo <matias.elo@nokia.com> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com> Reviewed-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
MatiasElo
force-pushed
the
dev/api-queue-create
branch
from
e81a4e4
to
91cb578
Compare
odpbuild
changed the title
MatiasElo
added
the
API Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move default queue type specification from odp_queue_create() to odp_queue_param_t to make it conform with the other parameters.
Also, explicitly state that queue size default value is zero. This was already tested by the validation test.