Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When phasing out corto, replace CompatibilityBundle ExceptionListeners with Symfony custom error pages #1770

Open
phavekes opened this issue Nov 29, 2024 · 4 comments

Comments

@phavekes
Copy link
Member

This issue is imported from pivotal - Originaly created at Nov 6, 2015 by Daan van Renterghem

Also refactor the FeedbackController and the way Response validation and Exceptions are handled.

@phavekes
Copy link
Member Author

The way Exceptions currently work in Corto/Bindings should be part of this refactoring as well. There are a lot of different Exceptions that are thrown and caught and some bubble up while others are not. This should be streamlined and cleaned up a bit. (Alex Rothuis - Nov 22, 2016)

@phavekes
Copy link
Member Author

Also, after the response has been received and processed, there is an assumption that the Response contains an Assertion. IMHO, this should be explicitly validated before continuing. (Alex Rothuis - Nov 23, 2016)

@phavekes
Copy link
Member Author

This includes the StuckInAuthenticationLoopException thrown by the AuthenticationLoopGuard as well.

We would like to replace communication by Exceptions with a proper SF-style Request/Response mechanism. (Alex Rothuis - Dec 8, 2016)

@phavekes
Copy link
Member Author

Thought should also be put into how to deal with non-mapped, non-api-specific exceptions (for instance: invalid HTTP method or authentication issues). Currently a default (feedback) page is shown, but this is probably not preferable when accessing the engine API. (Alex Rothuis - Apr 13, 2017)

@phavekes phavekes removed their assignment Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant