Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce SURFnet/StepupSamlBundle #1764

Open
phavekes opened this issue Nov 29, 2024 · 3 comments
Open

Introduce SURFnet/StepupSamlBundle #1764

phavekes opened this issue Nov 29, 2024 · 3 comments

Comments

@phavekes
Copy link
Member

This issue is imported from pivotal - Originaly created at Jan 6, 2016 by Daan van Renterghem

This opens the door to migrating the SAML functionality to the SamlBundle, allowing very easy SF integration and future PSR7 compliance.

Create an AuthenticationContext that can be used throughout the system for handling an Authn transaction. In the end it should contain all information with regards to requests and responses sent and received for the authentication, as well as the requesting SP, authenticating IdP, consent information, etc etc etc. Storable in the session.

Blocked by: #111132276

@phavekes
Copy link
Member Author

Makes sense to move this at least post-Symfony-4-upgrade? (Thijs Kinkhorst - Sep 11, 2019)

@phavekes
Copy link
Member Author

I don't see the benefits of using a Bundle. I would then opt for a library with PSR-7/PSR-15 support and no coupling with Symfony. Maybe the integration into Symfony would be a bit easier but currently it seems to be more work to maintain the Bundle and projects using the bundle. Certainly when major upgrades of Symfony come into play. Also the magic compiler passes could be omitted and the code will become much more easier and less time consuming to maintain in the future. (bstrooband - Apr 1, 2020)

@phavekes
Copy link
Member Author

We are already using the saml2 library of course.

Propose to remove this story as it lacks a clear problem it would solve. (Thijs Kinkhorst - Apr 3, 2020)

@phavekes phavekes removed their assignment Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant