Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the SamlIdGenerator #1757

Open
phavekes opened this issue Nov 29, 2024 · 0 comments
Open

Move the SamlIdGenerator #1757

phavekes opened this issue Nov 29, 2024 · 0 comments

Comments

@phavekes
Copy link
Member

This issue is imported from pivotal - Originaly created at Nov 25, 2019 by Michiel Kodde

In release 6.1 we moved the metadata generation features to the Symfony application. We did not move the 'SamlIdGenerator'. This generator is used to generate an unique id for SAML documents. (metadata, authnrequests and samlresponses).

Rule of thumb is to move any logic that is to be used in the SF application into the Symfony application (this can be a simple copy paste). But goal is to nog have a single depencency on library code in the new application.

What is to be done:

  1. Move the Generator to the SF application
  2. Make it into a service that is available in the DI container
  3. Facilitate the new Generator, using the bridge feature back into the library
  4. Et voila

Left-over from:
#168924689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant