Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issues and remove uses of nicegui #916

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Conversation

KIRA009
Copy link
Contributor

@KIRA009 KIRA009 commented Nov 8, 2024

What kind of change does this PR introduce?
This PR fixes build issues and removes uses of nicegui in the project

Summary
The PR fixes the build issue on windows where the numpy version was causing the build to fail on windows.

It also removes uses of nicegui and any deprecated scripts that are no longer being used

Checklist

  • My code follows the style guidelines of OpenAdapt
  • I have performed a self-review of my code
  • If applicable, I have added tests to prove my fix is functional/effective
  • I have linted my code locally prior to submission
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
  • New and existing unit tests pass locally with my changes

How can your code be run and tested?
Build the app on windows, then run it

Other information

Copy link
Member

@abrichr abrichr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abrichr abrichr merged commit de91850 into OpenAdaptAI:main Nov 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants