Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build stability #84

Open
3 of 4 tasks
JanssenBrm opened this issue Jun 21, 2023 · 5 comments
Open
3 of 4 tasks

Improve build stability #84

JanssenBrm opened this issue Jun 21, 2023 · 5 comments
Assignees

Comments

@JanssenBrm
Copy link
Collaborator

JanssenBrm commented Jun 21, 2023

The current instability in the library's build process creates a significant challenge as it obstructs the seamless update of versions. Consequently, the latest changes and improvements are unable to be successfully pushed to the final Python repositories. This situation directly affects users, as they are unable to access the most recent fixes and features of the library through the standard pip install process.

The following Python version should be supported in the build:

  • Python 3.8
  • Python 3.9
  • Python 3.10
  • Python 3.11
@JanssenBrm JanssenBrm self-assigned this Jun 21, 2023
@JanssenBrm
Copy link
Collaborator Author

JanssenBrm commented Jun 21, 2023

It looks like there is a dependency mismatch. The CCDC test (https://github.com/Open-EO/FuseTS/actions/runs/5333585954/jobs/9664241162 ) is currently failing with the following error:
AttributeError: module 'numpy' has no attribute 'bool'.

It looks likes that this numpy feature became deprecated as of 1.20.0 (https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations). However, we explicitly install a higher numpy version (numpy>=1.20.0) based on the setup.cfg.

I'm temporarily disabling this test to make sure the build gets fixed.

@jdries - Can you maybe take a look at this failing test?

@JanssenBrm JanssenBrm changed the title Build is failing Improve build stability Aug 4, 2023
@JanssenBrm JanssenBrm added bug Something isn't working WP4 WP4 WP2 WP2 labels Aug 4, 2023
@JanssenBrm
Copy link
Collaborator Author

Meanwhile, the issue seems to building the library for Python 3.10. This struggles with installing the vam.whittaker dependency.

@JanssenBrm
Copy link
Collaborator Author

This issue is also preventing #48

@soxofaan
Copy link
Member

pinning pip down below 23.0.1 seems to be a quickfix -> PR #97

@soxofaan
Copy link
Member

soxofaan commented Oct 4, 2023

FYI the build issues related to the whittaker depency should be resolved/improved now, with these fixes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants