Skip to content
This repository has been archived by the owner on Oct 31, 2022. It is now read-only.

Detect tools:node="replace" on the application tag in the main AndroidManifest.xml #22

Open
jkasten2 opened this issue Mar 28, 2018 · 2 comments

Comments

@jkasten2
Copy link
Member

jkasten2 commented Mar 28, 2018

Some app have the following in their main AndroidManifest.xml which causing OneSignal and Google Play services not to work or crash the app do to missing meta-data tags, services, actives, etc.

<application tools:node="replace">

This plugin should try to detect this and throw a build error to fail fast, instead of it becoming a hard to debug runtime error.

@birdeveloper
Copy link

I get the same error

@jkasten2
Copy link
Member Author

@gorkemkara16 This isn't an error to fix, instead this is a feature request to add an error/warning if <application tools:node="replace"> is detected since having it creates issues with most libraries.

I recommend opening a new issue with the problem you are having with this plugin if you are running into an issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants