Illegal symbol / minus in username shows as "Username taken"

[PhoenixIV]

Android, German

When changing my username (@ xxx) I tried to put a name with a - (minus). The result was the error message "Benutzername @ xy-z ist bereits vergeben" (En: Username taken). This applied to random usernames with - in it, there is no way these usernames were actually taken.

Expected behavior:
The error message says "Only xyz allowed", "You used an illegal character"
OR
Allow minus in usernames

This is about the German localization of the Okuna App. I did not try anything in other languages.

[duichwer]

@PhoenixIV does this still happen with the current release?

[PhoenixIV]

Yes

[duichwer]

Thanks for the reply. That helped me finding the correct trace:
The Api class that is called is checking if the username is taken, and if the characters are valid.
https://github.com/OkunaOrg/okuna-api/blob/9f3a0187df9cf7e3229ced2d8c45c348e126fabf/openbook_auth/views/auth/views.py#L85

Maybe the check inside the app should be turned around tho check at first the characters and then if the username is taken.

okuna-app/lib/pages/home/pages/profile/pages/edit_profile/modals/edit_profile.dart

Line 136 in 484e14f

if (_takenUsername != null &&

For Reference:
Have a look at the creation of an account e.g. :

okuna-app/lib/pages/auth/create_account/username_step.dart

Line 197 in b69294e

String validateUsernameResult = _validationService.validateUserUsername(username.trim());