Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log-format in templates #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mvdriel
Copy link
Member

@mvdriel mvdriel commented Apr 21, 2020

No description provided.

@tersmitten tersmitten added the bug label Apr 21, 2020
@tersmitten tersmitten added this to the 6.8.1 milestone Apr 21, 2020
@tersmitten
Copy link
Member

I have a feeling this is on purpose

@tersmitten
Copy link
Member

I see no quotes at all in the template(s)

@tersmitten
Copy link
Member

tersmitten commented Apr 21, 2020

The documentation should probably be:

e.g. `'"%{+Q}o\ %t\ %s\ %{-Q}r"'`

@tersmitten
Copy link
Member

Similar to:

    tcp_check:
      - 'send stats\r\n'
      - 'expect rstring "STAT pid [0-9]+"'
      - 'send quit\r\n'

@tersmitten
Copy link
Member

But I understand that this is not super intuitive

@mvdriel
Copy link
Member Author

mvdriel commented Apr 21, 2020

@tersmitten We could add more quotes in the templates. ;)

@tersmitten
Copy link
Member

Yes, but this will break existing installations and there's a workaround

@mvdriel
Copy link
Member Author

mvdriel commented Apr 21, 2020

@tersmitten Something for 7.* or do you prefer to keep it this way?

@tersmitten
Copy link
Member

Something for 7.*
Yes

But if I can find the time I prefer to make the role more like this one: https://github.com/Oefenweb/ansible-nginx#examples

"Raw" configuration is way more flexible and easier to maintain

@tersmitten tersmitten modified the milestones: 6.8.1, 7.0.0 Apr 22, 2020
@mvdriel
Copy link
Member Author

mvdriel commented Apr 22, 2020

The documentation should probably be:

e.g. `'"%{+Q}o\ %t\ %s\ %{-Q}r"'`

Yes, in: #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants