OXDEV-805 Revert the event returned on subscriber handler

OXID-eSales · Oct 9, 2024 · a196115 · a196115
1 parent e941436
commit a196115
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 15 deletions.
diff --git a/src/UserData/Event/UserDataExportCleanupSubscriber.php b/src/UserData/Event/UserDataExportCleanupSubscriber.php
@@ -24,14 +24,12 @@ public static function getSubscribedEvents(): array
         ];
     }
 
-    public function onUserDataExportCleanup(UserDataExportCleanupEventInterface&Event $event): Event
+    public function onUserDataExportCleanup(UserDataExportCleanupEventInterface&Event $event): void
     {
         $filePath = $event->getFilePath();
 
         if (file_exists($filePath)) {
             unlink($filePath);
         }
-
-        return $event;
     }
 }
diff --git a/tests/Unit/UserData/Event/UserDataExportCleanupSubscriberTest.php b/tests/Unit/UserData/Event/UserDataExportCleanupSubscriberTest.php
@@ -13,7 +13,6 @@
 use OxidEsales\GdprOptinModule\UserData\Event\UserDataExportCleanupSubscriber;
 use OxidEsales\GdprOptinModule\UserData\Event\UserDataExportCleanupEvent;
 use PHPUnit\Framework\TestCase;
-use Symfony\Contracts\EventDispatcher\Event;
 
 class UserDataExportCleanupSubscriberTest extends TestCase
 {
@@ -41,17 +40,6 @@ public function testOnUserDataExportCleanupUnlinkedFile(): void
         $this->assertFalse(file_exists($testFilePath));
     }
 
-    public function testOnUserDataExportCleanupReturnsEvent(): void
-    {
-        $userDataExportCleanupEventSpy = $this->createStub(UserDataExportCleanupEvent::class);
-
-        $sut = new UserDataExportCleanupSubscriber();
-
-        $handlerResult = $sut->onUserDataExportCleanup(event: $userDataExportCleanupEventSpy);
-
-        $this->assertInstanceOf(Event::class, $handlerResult);
-    }
-
     public function testSubscriberSubscribesToCorrectEvent(): void
     {
         $this->assertArrayHasKey(