Split plugin into multiple files for D3D and OpenGL/Android rendering paths #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of a zeroed viewport when that bug appears.
… collection code in the android branch to work similarly to the windows branch. Also fixed some link issues in the cmake for newer NDK API level targets, which fixes EntryPointNotFound exceptions.
… fix EntryPointNotFound exception
…toring and comments.
Closed
… plugin. Fixes crash on OSVR-Unity-Android when multithreaded rendering is enabled. Also removes some unnecessary code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double buffered rendering for Windows and Android. Differs from master branch in that it uses the RenderManager CAPI (instead of C++API) and an extra set of render buffers. Which set of buffers is used for rendering alternates each frame. This should give better performance when ATW is enabled.
D3D and Android-specific rendering sections have been removed from OsvrRenderingPlugin.cpp and split into classes which inherit from an abstract OsvrUnityRenderer.cs class. There is still some platform dependent code in OsvrRenderingPlugin.cpp, but this PR moves a lot of the platform-dependent code to OsvrD3DRenderer.cpp and OSVRAndroidRenderer.cpp
Needs a bit more testing before merging.
Requires: OSVR/OSVR-Unity#245
Replaces: #37