Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question concerning inclusion of unaged fish from Station 2 for kriged biomass apportionment #220

Closed
Tracked by #229
brandynlucca opened this issue Apr 1, 2024 · 2 comments · Fixed by #241
Closed
Tracked by #229
Assignees
Labels
design documentation Improvements or additions to documentation FEAT question

Comments

@brandynlucca
Copy link
Collaborator

The Matlab implementation assumes that all fish from Station 1 and Station 2 are "unaged" and "aged", respectively. However, there is a small proportion of fish from Station 2 that remain unaged for one reason or another. Currently, unaged fish from Station 2 are omitted/removed from the dataset entirely. Does it make sense for these unaged fish from Station 2 to be "lumped" together with the unaged fish from Station 1 since apportionment of kriged biomass is, conceptually, divided by "aged vs unaged" rather than "Station 1 vs 2"?

@brandynlucca brandynlucca added documentation Improvements or additions to documentation design question FEAT labels Apr 1, 2024
@brandynlucca brandynlucca self-assigned this Apr 1, 2024
@brandynlucca
Copy link
Collaborator Author

As discussed with PR #215, unaged fish should be dropped in the data loader. This should accompany documentation discussing the caveats of how unaged fish are explicitly handled from different data sets (i.e. Stations 1 and 2). This removal should accompany a console message (e.g. "_x_ unaged samples removed from Station 2 dataset").

@brandynlucca
Copy link
Collaborator Author

After discussing this with FEAT and reviewing the original EchoPro implementation, the updated echopop implementation reflected in PR #241 represents the equivalent workflow as in EchoPro. The unaged fish from Station 2 are retained so they can contribute to the overall length-weight regression fit that is then applied to both aged (Station 2) and unaged (Station 1) fish. These unaged fish are ultimately removed anyways later on in the analysis since apportionment is, in part, a function of age-bins.

This can therefore be closed once PR #241 is merged.

@github-project-automation github-project-automation bot moved this from In review to Done in Echopop Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design documentation Improvements or additions to documentation FEAT question
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants