Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't select favorite as the directory directly #204

Open
Micket opened this issue Sep 12, 2023 · 5 comments
Open

Can't select favorite as the directory directly #204

Micket opened this issue Sep 12, 2023 · 5 comments

Comments

@Micket
Copy link

Micket commented Sep 12, 2023

Using data-target-file-type: dirs and selecting a Favorite and pressing "Select" doesn't pick up the directory. I have to select something on the right hand side, but the . directory isn't selectable, there is no way to directly use a favorite.
Instead, I have to go 1 dir up, which in my case means hundreds of project directories, and requires that I scroll to my project area manually.
I also have no way of not selecting a subdirectory when such a dir exists, again forcing me to go up 1 dir.

I'm also not sure my users would necessarily recognize . and .. even if they were selectable.

@johrstrom
Copy link
Contributor

Hi, thanks for the ticket - but I have to say it won't be worked. This is being replaced in 3.1 with a native path_selector widget.

OSC/ondemand#1571

That said - it (the newer implementation) doesn't show favorites at all at the moment (and likely won't in 3.1 because it's coming soon) but I made a ticket for the same.

@johrstrom
Copy link
Contributor

Well I should say, it won't be worked by OSC. If you submit a patch for this issue (or the other), I'd be happy to review and merge it.

@Micket
Copy link
Author

Micket commented Sep 12, 2023

I was new to the file picker to begin with, wasn't aware of the native widgets WIP. I'll be happy to jump over to 3.1 as soon as possible!

@johrstrom
Copy link
Contributor

Well there's an open pull request to maybe fix this so I can reopen.

@johrstrom johrstrom reopened this Sep 14, 2023
@johrstrom
Copy link
Contributor

Also - I can't seem to replicate on OOD 3.0.1 and this library at 3.0.1 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants