Use fmt 0.9.0 to prevent conflict with the result library #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alt-ergo.opam.template
Outdated
Comment on lines
10
to
12
| conflicts: [ | ||
| "result" {< "1.5"} | ||
| ] |
There was a problem hiding this comment.
Dependencies should be specified in the dune-project (here with a (conflicts) field in the package declaration, see https://dune.readthedocs.io/en/stable/dune-files.html#stanza-package ), not in the template file.
There was a problem hiding this comment.
Thanks! I didn't find the right stanza.
Halbaroth
changed the title
bclement-ocp
approved these changes
Sep 11, 2023
Halbaroth
added a commit
to Halbaroth/alt-ergo
that referenced
this pull request
Sep 15, 2023
* conflict with result < 1.5 * Use fmt >= 0.9.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevent conflict with old version of the library
result. After this PR, Alt-Ergo depends on this library throughFmt >= 0.9.0.We have to backport this fix on the branch
v2.5.x.