Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] product_pricelist_simulation "Unit sales price" is not updated when the date is changed #1466

Open
FreezeS opened this issue Nov 24, 2023 · 4 comments
Labels

Comments

@FreezeS
Copy link

FreezeS commented Nov 24, 2023

Hi guys,

I'm testing the product_pricelist_simulation module.
I have two pricelists, Master and LAB2 (derived from Master).

Pricelist LAB2 has 2 rules:
image

When I click on View Price per Pricelist, I get this:
image
This applies the 10% discount rule correctly.

However, if I change the date, nothing happens:
image

For the selected date is should have applied the 90% discount rule.

@FreezeS FreezeS added the bug label Nov 24, 2023
@legalsylvain
Copy link
Contributor

legalsylvain commented Nov 24, 2023

Hi @FreezeS. Thanks for reporting.
Indeed, something is wrong in this function.

https://github.com/OCA/product-attribute/blob/16.0/product_pricelist_simulation/wizards/wizard_preview_pricelist.py#L46
price_date is not used and should be passed in _price_get.

It looks to be a regression introduced here 6f0d322#diff-23b9cef8dea11713559764c80590be7f0db6a68d06563c799d1693f1ada8b1dcR59 in #1348

Note : also changing the quantity should fail.

@HugoCordobaLeal, could you take a look ?
thanks !

@hugo-cordoba
Copy link
Contributor

Hi @FreezeS @legalsylvain.

Thanks for reporting the error, I will take a look at it during the day when I have a free moment. I'll let you know.

Copy link

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 26, 2024
@legalsylvain
Copy link
Contributor

@hugo-cordoba : any news on that topic ?

Thanks !

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants