Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] purchase_mrp_distribution: New module to distribute qty of move in diferent products #1300

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

CarlosRoca13
Copy link
Contributor

@CarlosRoca13 CarlosRoca13 commented Jul 9, 2024

This module aims to address the need to receive a generic product, but until the moment of reception, we do not know the quantity that we might receive of its specific products.

Using kits was not suitable for us, because to account for a unit of the kit product, the quantity specified in the BoM must be received. Therefore, we opted to define a new type of BoM called distribution.

In this way, upon receiving a unit of any product added to the BoM, it will be accounted for as a unit of the generic product and will be reflected in the svls as separate products, but they will be accounted for in the purchase line as part of the product.

cc @Tecnativa TT49937

ping @pedrobaeza @victoralmau

@CarlosRoca13 CarlosRoca13 force-pushed the 15.0-ADD-purchase_mrp_distribution branch 3 times, most recently from af30362 to 08da4d8 Compare July 12, 2024 11:34
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review OK.

@bosd
Copy link

bosd commented Nov 3, 2024

@CarlosRoca13 Can you please rebase to recreate a runboat?

@CarlosRoca13 CarlosRoca13 force-pushed the 15.0-ADD-purchase_mrp_distribution branch from 08da4d8 to 5432700 Compare November 4, 2024 07:00
@CarlosRoca13
Copy link
Contributor Author

@bosd done!

Copy link

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fucntional test. LGTM

@CarlosRoca13
Copy link
Contributor Author

ping @pedrobaeza

@pedrobaeza pedrobaeza added this to the 15.0 milestone Nov 11, 2024
… in diferent products

This module aims to address the need to receive a
generic product, but until the moment of reception,
we do not know the quantity that we might receive
of its specific products.

Using kits was not suitable for us, because to
account for a unit of the kit product, the quantity
specified in the BoM must be received. Therefore,
we opted to define a new type of BoM called
distribution.

In this way, upon receiving a unit of any product
added to the BoM, it will be accounted for as a
unit of the generic product and will be reflected
in the svls as separate products, but they will be
accounted for in the purchase line as part of the
product.
@pedrobaeza pedrobaeza force-pushed the 15.0-ADD-purchase_mrp_distribution branch from 5432700 to 0ea4e39 Compare November 11, 2024 07:36
@bosd
Copy link

bosd commented Nov 11, 2024

Oops, I missed the filling test.
Can you look into it?

@pedrobaeza
Copy link
Member

It's not our fault... #1388

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1300-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a2390aa into OCA:15.0 Nov 12, 2024
3 of 5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 191403b. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-ADD-purchase_mrp_distribution branch November 12, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants