[14.0][ADD] mrp_subcontracting_purchase #1082

Volodiay622 · 2023-08-28T04:42:07Z

No description provided.

francesco-ooops · 2023-09-07T14:34:53Z

@pedrobaeza could you please provide us instructions on how to correctly bring to merge this PR?

eg. regarding authorship and commits, as this is the backporting to v14 of odoo module https://github.com/odoo/odoo/tree/15.0/addons/mrp_subcontracting_purchase

Thanks!

pedrobaeza · 2023-09-07T14:39:01Z

First, you should add a commit attributed to "Odoo SA odoo@odoo.com" with the contents as they are in the new version, and then add your commits with the changes needed to work on this version.

Then, check https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#10backporting-odoo-modules

Aldeigja · 2023-09-14T08:03:21Z

First, you should add a commit attributed to "Odoo SA odoo@odoo.com" with the contents as they are in the new version, and then add your commits with the changes needed to work on this version.

Then, check https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#10backporting-odoo-modules

@pedrobaeza To make mrp_subcontracting_purchase work as per v15, we also had to port code from v15 of Odoo modules:

mrp_subcontracting_purchase,
mrp_subcontracting_dropshipping,
purchase_mrp,
purchase_stock

how do you suggest to proceed for code from those modules?

pedrobaeza · 2023-09-14T08:50:13Z

You have to include the needed changes in your module, trying to be the most compatible possible. I needed to do similar things when I backported mrp_subcontracting. Some examples:

f32ce8b#diff-96c2f57c6a07eb25b5e8b5cbc49574423aa16aa8fbb1c50672de67d9a25aca56R150
f32ce8b#diff-96c2f57c6a07eb25b5e8b5cbc49574423aa16aa8fbb1c50672de67d9a25aca56L204
f32ce8b#diff-024c81702831beef5a3aaf69d8fb0342d470277883158ee96b248722f102a33bR20

geomer198

Please check my comments and upper your tests coverage.

geomer198 · 2023-09-29T22:10:38Z

mrp_subcontracting_purchase/models/stock_rule.py

+    def _prepare_purchase_order(self, company_id, origins, values):
+        """Returns prepared data for create PO"""
+        if (
+            "partner_id" not in values[0]


value may be empty? If value will be empty than you need check this before this condition.

value is checking here

geomer198 · 2023-09-29T22:11:54Z

mrp_subcontracting_purchase/models/stock_rule.py

+            if po.origin:
+                missing_origins = origins - set(po.origin.split(", "))
+                if missing_origins:
+                    po.write({"origin": po.origin + ", " + ", ".join(missing_origins)})


Could you use format function for preparing string value?

geomer198 · 2023-09-29T22:14:06Z

mrp_subcontracting_purchase/models/mrp_production.py

+    def _pre_button_mark_done(self):
+        if self._get_subcontract_move():
+            return True
+        return super()._pre_button_mark_done()


You can do like this (optional):

return True if self._get_subcontract_move() else super()._pre_button_mark_done()

applied, thanks

geomer198 · 2023-09-29T22:15:59Z

mrp_subcontracting_purchase/models/mrp_production.py

+        # which checks whether the subcontracting has been recorded or not
+
+        def filter_in(mo):
+            if (


You can inverse this big condition and write return without if:

return not (mo.state in ("done", "cancel") .......)`

geomer198 · 2023-09-29T22:21:55Z

mrp_subcontracting_purchase/models/purchase_order.py

+                    Please create a separate order for these."""
+                )
+                + "\n\n"
+                + "\n".join(not_in_bom_products.mapped("name"))


It's not good idea, you must use format like this for one variable _("....... \n\n%s", value).

geomer198 · 2023-09-29T22:27:01Z

mrp_subcontracting_purchase/models/stock_move.py

+    def _compute_show_subcontracting_details_visible(self):
+        """Compute if the action button in order to see moves raw is visible"""
+        self.show_subcontracting_details_visible = False
+        for move in self:


I think need add the filter for self

for move in self.filtered("is_subcontract"): ....

geomer198 · 2023-09-29T22:27:26Z

mrp_subcontracting_purchase/models/stock_move.py

+        show details button is visible.
+        """
+        res = super(StockMove, self)._compute_show_details_visible()
+        for move in self:


francesco-ooops

Functional ok!

We should be good here, full test coverage and documentation

@pedrobaeza can we ask for your feedback? Thanks!

francesco-ooops · 2023-10-10T08:36:14Z

@david-fleischmann would this help your flow?

pedrobaeza · 2023-10-10T10:11:08Z

I'm not seeing an initial commit authored by Odoo SA with the content as is on the next version, and then, all your modifications to make it work in v14.

Add a new module to add smart buttons between a subcontracting purchase order and the ressuply component delivery. task-2486811 Part-of: odoo/odoo#75041

…work

geomer198 · 2023-10-13T10:19:41Z

@pedrobaeza Could you check repository structure please?
Now is correct?

pedrobaeza · 2023-10-13T10:24:25Z

mrp_subcontracting_purchase/README.rst

@@ -0,0 +1,2 @@
+This module is a backport from Odoo SA and as such, it is not included in the OCA CLA.


Suggested change

This module is a backport from Odoo SA and as such, it is not included in the OCA CLA.

This bridge module adds some smart buttons between Purchase and Subcontracting

**DISCLAIMER:** This module is a backport from Odoo SA and as such, it is not included in the OCA CLA.

Oh, I see that you have a DESCRIPTION.rst in the readme folder, so you have to introduce the disclaimer there.

Oh, I see that you have a DESCRIPTION.rst in the readme folder, so you have to introduce the disclaimer there.

Resolved

mrp_subcontracting_purchase/demo/0001_demo_product_category.xml

pedrobaeza · 2023-10-13T17:53:37Z

mrp_subcontracting_purchase/README.rst

@@ -0,0 +1,5 @@
+This bridge module adds some smart buttons between Purchase and Subcontracting
+
+**DISCLAIMER:** This module is a backport from Odoo SA and as such, it is not included in the OCA CLA.


This should be put on readme/DESCRIPTION.rst, not here.

pedrobaeza · 2023-10-13T20:14:54Z

/ocabot merge nobump

OCA-git-bot · 2023-10-13T20:15:03Z

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1082-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-10-13T20:31:29Z

Congratulations, your PR was merged at c2c7aaa. Thanks a lot for contributing to OCA. ❤️

francesco-ooops · 2023-10-16T07:56:54Z

Hi @pedrobaeza , thanks for your support on this one.

Do you have any idea why the "Configuration" file is not appearing in readme here?: https://github.com/OCA/manufacture/tree/14.0/mrp_subcontracting_purchase

Do you think it's a .md issue?

pedrobaeza · 2023-10-16T08:10:24Z

It should be CONFIGURE.md, not CONFIGURATION.md.

david-fleischmann · 2024-05-02T16:33:19Z

@francesco-ooops thank you! Just found that notifications from github in my spam folder... sorry for that late reply!
I'll check this feature on our side within the next weeks. Best, David

Volodiay622 marked this pull request as draft August 28, 2023 04:42

Volodiay622 force-pushed the 14.0-t2784-mrp_subcontracting_purchase-add_module branch 2 times, most recently from cc876fc to f0fd491 Compare September 7, 2023 20:01

Volodiay622 force-pushed the 14.0-t2784-mrp_subcontracting_purchase-add_module branch 6 times, most recently from bb17a10 to e91ef71 Compare September 25, 2023 00:04

francesco-ooops mentioned this pull request Sep 25, 2023

Bug in mrp_subcontracting_partner_management: No qty_received when delivering from one subcontractor to another #1024

Closed

Volodiay622 marked this pull request as ready for review September 26, 2023 17:20

geomer198 reviewed Sep 29, 2023

View reviewed changes

geomer198 force-pushed the 14.0-t2784-mrp_subcontracting_purchase-add_module branch 3 times, most recently from 5c50253 to 8dc1fe4 Compare October 9, 2023 18:23

francesco-ooops approved these changes Oct 10, 2023

View reviewed changes

pedrobaeza added this to the 14.0 milestone Oct 10, 2023

mrp_subcontracting_purchase: new module copied from 15.0

d59b6b6

Add a new module to add smart buttons between a subcontracting purchase order and the ressuply component delivery. task-2486811 Part-of: odoo/odoo#75041

geomer198 force-pushed the 14.0-t2784-mrp_subcontracting_purchase-add_module branch from 8dc1fe4 to 51c7c06 Compare October 13, 2023 10:14

[MIG] mrp_subcontracting_purchase: Adapt to OCA guidelines + initial …

89fd156

…work

geomer198 force-pushed the 14.0-t2784-mrp_subcontracting_purchase-add_module branch from 51c7c06 to 0765765 Compare October 13, 2023 10:16

pedrobaeza reviewed Oct 13, 2023

View reviewed changes

mrp_subcontracting_purchase/demo/0001_demo_product_category.xml Outdated Show resolved Hide resolved

[MIG] mrp_subcontracting_purchase: Adapt to 14.0

93cd12b

geomer198 force-pushed the 14.0-t2784-mrp_subcontracting_purchase-add_module branch from a1c6816 to 93cd12b Compare October 13, 2023 16:21

pedrobaeza reviewed Oct 13, 2023

View reviewed changes

[FIX] mrp_subcontracting_purchase: DESCRIPTION is updated.

7634fe7

OCA-git-bot added the bot is merging ⏳ label Oct 13, 2023

OCA-git-bot merged commit 095cef7 into OCA:14.0 Oct 13, 2023
6 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][ADD] mrp_subcontracting_purchase #1082

[14.0][ADD] mrp_subcontracting_purchase #1082

Volodiay622 commented Aug 28, 2023

francesco-ooops commented Sep 7, 2023

pedrobaeza commented Sep 7, 2023

Aldeigja commented Sep 14, 2023

pedrobaeza commented Sep 14, 2023

geomer198 left a comment

geomer198 Sep 29, 2023

Volodiay622 Sep 30, 2023

geomer198 Sep 29, 2023

Volodiay622 Sep 30, 2023

geomer198 Sep 29, 2023

Volodiay622 Sep 30, 2023

geomer198 Sep 29, 2023

geomer198 Sep 29, 2023

geomer198 Sep 29, 2023

geomer198 Sep 29, 2023

francesco-ooops left a comment

francesco-ooops commented Oct 10, 2023

pedrobaeza commented Oct 10, 2023

geomer198 commented Oct 13, 2023

pedrobaeza Oct 13, 2023

pedrobaeza Oct 13, 2023

geomer198 Oct 13, 2023

pedrobaeza Oct 13, 2023

pedrobaeza commented Oct 13, 2023

OCA-git-bot commented Oct 13, 2023

OCA-git-bot commented Oct 13, 2023

francesco-ooops commented Oct 16, 2023

pedrobaeza commented Oct 16, 2023

david-fleischmann commented May 2, 2024

		@@ -0,0 +1,2 @@
		This module is a backport from Odoo SA and as such, it is not included in the OCA CLA.

		@@ -0,0 +1,5 @@
		This bridge module adds some smart buttons between Purchase and Subcontracting

		DISCLAIMER: This module is a backport from Odoo SA and as such, it is not included in the OCA CLA.

[14.0][ADD] mrp_subcontracting_purchase #1082

[14.0][ADD] mrp_subcontracting_purchase #1082

Conversation

Volodiay622 commented Aug 28, 2023

francesco-ooops commented Sep 7, 2023

pedrobaeza commented Sep 7, 2023

Aldeigja commented Sep 14, 2023

pedrobaeza commented Sep 14, 2023

geomer198 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

francesco-ooops left a comment

Choose a reason for hiding this comment

francesco-ooops commented Oct 10, 2023

pedrobaeza commented Oct 10, 2023

geomer198 commented Oct 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Oct 13, 2023

OCA-git-bot commented Oct 13, 2023

OCA-git-bot commented Oct 13, 2023

francesco-ooops commented Oct 16, 2023

pedrobaeza commented Oct 16, 2023

david-fleischmann commented May 2, 2024