Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update our tooling to support Odoo 16.0 #537

Closed
20 of 22 tasks
sbidoul opened this issue Sep 21, 2022 · 19 comments
Closed
20 of 22 tasks

Update our tooling to support Odoo 16.0 #537

sbidoul opened this issue Sep 21, 2022 · 19 comments

Comments

@sbidoul
Copy link
Member

sbidoul commented Sep 21, 2022

What needs to be done to create the 16.0 branches

See #509 for links to similar PRs for 15.0.

@pedrobaeza

This comment was marked as resolved.

@legalsylvain

This comment was marked as resolved.

@pedrobaeza

This comment was marked as resolved.

@pedrobaeza

This comment was marked as resolved.

@carmenbianca
Copy link
Member

I'll have a look at oca-ci.

@carmenbianca
Copy link
Member

oca-ci PR: OCA/oca-ci#37

@sbidoul
Copy link
Member Author

sbidoul commented Sep 22, 2022

runboat is up for OCB 16.0: https://runboat.odoo-community.org/builds?repo=oca/ocb

@sbidoul
Copy link
Member Author

sbidoul commented Sep 26, 2022

If anyone wants to try updating the repo template, that is welcome as I have little available time this week.
Mostly, we need to pick-up the latest linters (doing a dry-run of pre-commit autoupdate on an existing repo will give the versions to use), and determine which pylint-odoo rules to make mandatory, and the new ones to enable.

@lmignon
Copy link
Contributor

lmignon commented Sep 26, 2022

@sbidoul I'll take a look at the repo template.

@lmignon
Copy link
Contributor

lmignon commented Sep 26, 2022

oca-addons-repo-template PR: OCA/oca-addons-repo-template#160

@lmignon
Copy link
Contributor

lmignon commented Sep 27, 2022

looking at oca-github-bot, the only thing that would need to be changed is the config on the server in the environment file to add version 16.0 in MAINTAINER_CHECK_ODOO_RELEASES

@pedrobaeza
Copy link
Member

Why not adding from 16.0 to for example 20.0 for not having to worry about this part in some years?

@lmignon
Copy link
Contributor

lmignon commented Sep 28, 2022

IMO the topics determine python and postgres version to use in CI and update [addons repo template](https://github.com/OCA/maintainer-tools/issues/github.com/oca/oca-addons-repo-template) can be ticked as done.
For the record I manually created the 16.0 branch on the rest-framework repo and created a first PR to check that runboat works as expected with odoo 16.0. -> 🍾

@pedrobaeza
Copy link
Member

Should we proceed with the 16.0 branches creation? @sbidoul are you going to do like other years?

@sbidoul
Copy link
Member Author

sbidoul commented Sep 28, 2022

I'll do it yes. I was planning to do it this weekend if everything is ready.

Last open question I think is the pylint configs: OCA/oca-addons-repo-template#160 (comment)

@sbidoul
Copy link
Member Author

sbidoul commented Oct 3, 2022

I prepared OCA/social: OCA/social#974. All looking good.
Still waiting a little bit for input about pylint-odoo before opening all other repos.

@TheMule71
Copy link

Hi. I don't really know how to propose changes to Wiki pages (the edit buttton escapes me), so I'm gonna add a comment here.

IMHO the following items are worth considering as additions to the guide https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0:

  • odoo/odoo@26b2472 changes to account.account: account.account.type model is no more, now account_type is a selection field.
  • odoo/odoo@d8d47f9 accounting v16 - refactoring of @onchange methods. Some synchronization methods have been removed, there's less need to explicitly call methods to recompute account.move internals when making changes from python
  • odoo/odoo@2348386 some fields became HTML from Text - this may affect you if you read/write them in python code

@pedrobaeza
Copy link
Member

Hi, Marco, I'm afraid GitHub doesn't still offer any way to do such suggestion (or that seems so - https://stackoverflow.com/questions/10642928/how-can-i-make-a-pull-request-for-a-wiki-page-on-github).

Anyway, the changes we put there are the framework ones, not the data model ones, as this last category is very long (see OCA/OpenUpgrade#3583 for the whole list of changes), and it will lose the focus of the guide, as you may not need to know those changes to make the migration (it depends on what are you touching).

@TheMule71
Copy link

TheMule71 commented Nov 8, 2022

It makes sense, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants