From d477e044a2c5a7de85656a3aa0fd40a26e7fd864 Mon Sep 17 00:00:00 2001
From: "matthieu.saison" <matthieu.saison@akretion.br.com>
Date: Tue, 19 Nov 2024 15:34:14 +0100
Subject: [PATCH] fix wizard amount residual not computed

---
 .../data/mail_template.xml                        |  2 +-
 .../wizard/overdue_reminder_wizard.py             | 15 +++++++++++++++
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/account_invoice_overdue_reminder/data/mail_template.xml b/account_invoice_overdue_reminder/data/mail_template.xml
index 251bcc20e..c158862d7 100644
--- a/account_invoice_overdue_reminder/data/mail_template.xml
+++ b/account_invoice_overdue_reminder/data/mail_template.xml
@@ -41,7 +41,7 @@
         <th style="padding: 5px; border: 1px solid black;">Residual</th>
         <th style="padding: 5px; border: 1px solid black;">Past Reminders</th>
     </tr>
-% for inv in object.invoice_ids.sorted(key='invoice_date'):
+% for inv in object.get_invoices().sorted(key='invoice_date'):
     <tr style="background-color:
         % if inv.move_type == 'out_refund':
             LightGray
diff --git a/account_invoice_overdue_reminder/wizard/overdue_reminder_wizard.py b/account_invoice_overdue_reminder/wizard/overdue_reminder_wizard.py
index 626263a90..2694109ce 100644
--- a/account_invoice_overdue_reminder/wizard/overdue_reminder_wizard.py
+++ b/account_invoice_overdue_reminder/wizard/overdue_reminder_wizard.py
@@ -385,6 +385,21 @@ class OverdueReminderStep(models.TransientModel):
     def _reminder_type_selection(self):
         return self.env["overdue.reminder.action"]._reminder_type_selection()
 
+    # Fix bug:
+    # When removing a invoice in the interface the field "mail_body" is recomputed in "onchange mode".
+    # This mean that the field "invoice_ids" have New Record (NewId) instead of real record.
+    # The issue is that the field "amount_residual" do not work with New Record
+    # due to "if line.id" here
+    # https://github.com/odoo/odoo/blob/cc0060e889603eb2e47fa44a8a22a70d7d784185
+    # /addons/account/models/account_move.py#L4029
+
+    # And so the amount_residual will be always be recomputed by the onchange to 0
+
+    # To avoid this issue we force in the template to use real invoices (get_invoices ())
+
+    def get_invoices(self):
+        return self.env["account.move"].browse(self.invoice_ids.ids)
+
     @api.depends("invoice_ids", "user_id", "partner_id")
     def _compute_counter_and_mail(self):
         xmlid = self._get_overdue_invoice_reminder_template()