By Barak Shoshany
Email: baraksh@gmail.com
Website: https://baraksh.com/
GitHub: https://github.com/bshoshany
BS_thread_pool.hpp
:- The public member variable
paused
ofBS::thread_pool
has been made private for future-proofing (in case future versions implement a more involved pausing mechanism) and better encapsulation. It is now accessible only via thepause()
,unpause()
, andis_paused()
member functions. In other words:- Replace
pool.paused = true
withpool.pause()
. - Replace
pool.paused = false
withpool.unpause()
. - Replace
if (pool.paused)
(or similar) withif (pool.is_paused())
.
- Replace
- The public member variable
f
ofBS::multi_future
has been renamed tofutures
for clarity, and has been made private for encapsulation and simplification purposes. Instead of operating on the vectorfutures
itself, you can now use the[]
operator of theBS::multi_future
to access the future at a specific index directly, or thepush_back()
member function to append a new future to the list. Thesize()
member function tells you how many futures are currently stored in the object. - The explicit casts of
std::endl
andstd::flush
, added in v3.2.0 to enable flushing aBS::synced_stream
, caused ODR (One Definition Rule) violations ifBS_thread_pool.hpp
was included in two different translation units, since they were mistakenly not defined asinline
. To fix this, I decided to make them static members ofBS::synced_stream
instead of global variables, which also makes the code better organized in my opinion. These objects can now be accessed asBS::synced_stream::endl
andBS::synced_stream::flush
. I also added an example for how to use them inREADME.md
. See #64.
- The public member variable
BS_thread_pool_light.hpp
:- This package started out as a very lightweight thread pool, but over time has expanded to include many additional features, and at the time of writing it has a total of 340 lines of code, including all the helper classes. Therefore, I have decided to bundle a light version of the thread pool in a separate and stand-alone header file,
BS_thread_pool_light.hpp
, with only 170 lines of code (half the size of the full package). This file does not contain any of the helper classes, only a newBS::thread_pool_light
class, which is a minimal thread pool with only the 5 most basic member functions:get_thread_count()
push_loop()
push_task()
submit()
wait_for_tasks()
- A separate test program
BS_thread_pool_light_test.cpp
tests only the features of the lightweightBS::thread_pool_light
class. In the spirit of minimalism, it does not generate a log file and does not do any benchmarks. - To be perfectly clear, each header file is 100% stand-alone. If you wish to use the full package, you only need
BS_thread_pool.hpp
, and if you wish to use the light version, you only needBS_thread_pool_light.hpp
. Only a single header file needs to be included in your project.
- This package started out as a very lightweight thread pool, but over time has expanded to include many additional features, and at the time of writing it has a total of 340 lines of code, including all the helper classes. Therefore, I have decided to bundle a light version of the thread pool in a separate and stand-alone header file,
BS_thread_pool.hpp
:- Main
BS::thread_pool
class:- Added a new member function,
push_loop()
, which does the same thing asparallelize_loop()
, except that it does not return aBS::multi_future
with the futures for each block. Just likepush_task()
vs.submit()
, this avoids the overhead of creating the futures, but the user must usewait_for_tasks()
or some other method to ensure that the loop finishes executing, otherwise bad things will happen. push_task()
andsubmit()
now utilize perfect forwarding in order to support more types of tasks - in particular member functions, which in previous versions could not be submitted unless wrapped in a lambda. To submit a member function, use the syntaxsubmit(&class::function, &object, args)
. More information can be found inREADME.md
. See #9.push_loop()
andparallelize_loop()
now have overloads where the first argument (the first index in the loop) is omitted, in which case it is assumed to be 0. This is for convenience, as the case where the first index is 0 is very common.
- Added a new member function,
- Helper classes:
BS::synced_stream
now utilizes perfect forwarding in the member functionsprint()
andprintln()
.- Previously, it was impossible to pass the flushing manipulators
std::endl
andstd::flush
toprint()
andprintln()
, since the compiler could not figure out which template specializations to use. The new objectsBS::endl
andBS::flush
are explicit casts of these manipulators, whose sole purpose is to enable passing them toprint()
andprintln()
. BS::multi_future::get()
now rethrows exceptions generated by the futures, even if the futures returnvoid
. See #62.- Added a new helper class,
BS::blocks
, which is used byparallelize_loop()
andpush_loop()
to divide a range into blocks. This class is not documented inREADME.md
, as it most likely will not be of interest to most users, but it is still publicly available, in case you want to parallelize something manually but still benefit from the built-in algorithm for splitting a range into blocks.
- Main
BS_thread_pool_test.cpp
:- Added plenty of new tests for the new features described above.
- Fixed a bug in
count_unique_threads()
that caused it to get stuck on certain systems. dual_println()
now also flushes the stream usingBS::endl
, so that if the test gets stuck, the log file will still contain everything up to that point. (Note: It is a common misconception thatstd::endl
and'\n'
are interchangeable.std::endl
not only prints a newline character, it also flushes the stream, which is not always desirable, as it may reduce performance.)- The performance test has been modified as follows:
- Instead of generating random vectors using
std::mersenne_twister_engine
, which proved to be inconsistent across different compilers and systems, the test now generates each element via an arbitrarily-chosen numerical operation. In my testing, this provided much more consistent results. - Instead of using a hard-coded vector size, a suitable vector size is now determined dynamically at runtime.
- Instead of using
parallelize_loop()
, the test now uses the newpush_loop()
function to squeeze out a bit more performance. - Instead of setting the test parameters to achieve a fixed single-threaded mean execution time of 300 ms, the test now aims to achieve a fixed multi-threaded mean execution time of 50 ms when the number of blocks is equal to the number of threads. This allows for more reliable results on very fast CPUs with a very large number of threads, where the mean execution time when using all the threads could previously be below a statistically significant value.
- The number of vectors is now restricted to be a multiple of the number of threads, so that the blocks are always all of the same size.
- Instead of generating random vectors using
README.md
:- Added instructions and examples for the new features described above.
- Rewrote the documentation for
parallelize_loop()
to make it clearer.
BS_thread_pool.hpp
:- Fixed an issue where
wait_for_tasks()
would sometimes get stuck ifpush_task()
was executed immediately beforewait_for_tasks()
. - Both the thread pool constructor and the
reset()
member function now determine the number of threads to use in the pool as follows. If the parameter is a positive number, then the pool will be created with this number of threads. If the parameter is non-positive, or a parameter was not supplied, then the pool will be created with the total number of hardware threads available, as obtained fromstd::thread::hardware_concurrency()
. If the latter returns a non-positive number for some reason, then the pool will be created with just one thread. See #51 and #52. - Added the
[[nodiscard]]
attribute to classes and class members, in order to warn the user when accidentally discarding an important return value, such as a future or the return value of a function with no useful side-effects. For example, if you usesubmit()
and don't save the future it returns, the compiler will now generate a warning. (If a future is not needed, then you should usepush_task()
instead.) - Removed the
explicit
specifier from all constructors, as it prevented the default constructor from being used with static class members. See #48.
- Fixed an issue where
BS_thread_pool_test.cpp
:- Improved
count_unique_threads()
using condition variables, to ensure that each thread in the pool runs at least one task regardless of how fast it takes to run the tasks. - When appropriate,
check()
now explicitly reports what the obtained result was and what it was expected to be. check_task_monitoring()
andcheck_pausing()
now explicitly report the results of the monitoring at each step.- Changed all instances of
std::vector<std::atomic<bool>>
tostd::unique_ptr<std::atomic<bool>[]>
. See #44. - Converted a few more C-style casts to C++ cast expressions.
- Improved
README.md
:- Added instructions for using this package with the Conan C/C++ package manager. Please refer to this package's page on ConanCenter to learn how to use Conan to include this package in your project with various build systems.
- If you found this project useful, please consider starring it on GitHub! This allows me to see how many people are using my code, and motivates me to keep working to improve it.
- This is a major new release with many changes and improvements! Please note that code written using previous releases will need to be slightly modified to work with the new release. The changes needed to migrate to the new API are explicitly indicated below for your convenience.
- Breaking changes to the library header file:
- The header file has been renamed to
BS_thread_pool.hpp
to avoid potential conflict with other thread pool libraries.- API migration: The library must now be included by invoking
#include "BS_thread_pool.hpp"
.
- API migration: The library must now be included by invoking
- All the definitions in the library, including the
thread_pool
class and the helper classes, are now located in the namespaceBS
. This namespace will also be used for my other C++ projects, and is intended to ensure consistency between my projects while avoiding potential name conflicts with other libraries.- API migration: The thread pool class should now be invoked as
BS::thread_pool
. Alternatively, it is possible to employusing BS::thread_pool
or evenusing namespace BS
and then invokethread_pool
directly. Same for theBS::synced_stream
andBS::timer
helper classes.
- API migration: The thread pool class should now be invoked as
- The macro
THREAD_POOL_VERSION
, which contains the version number and release date of the library, has been renamed toBS_THREAD_POOL_VERSION
to avoid potential conflicts.- API migration: The version must now be read from the macro
BS_THREAD_POOL_VERSION
.
- API migration: The version must now be read from the macro
- The public member
sleep_duration
has been removed. The thread pool now uses condition variables instead of sleep to facilitate waiting. This significantly improves performance (by 10%-50% in my testing), drastically decreases idle CPU utilization, and eliminates the need to set an optimal sleep time. This was a highly-requested change; see issue #1, issue #12, and pull request #23.- API migration: Remove any code that relates to the public member
sleep_duration
.
- API migration: Remove any code that relates to the public member
- The template specializations for
submit()
have been merged. Now instead of two versions, one for functions with a return value and one for functions without a return value, there is just one version, which can accept any function. This makes the code more compact (and elegant). If a function with no return value is submitted, anstd::future<void>
is returned (the previous version returned anstd::future<bool>
)- API migration: To wait for a task with no return value, simply call
wait()
orget()
on the correspondingstd::future<void>
.
- API migration: To wait for a task with no return value, simply call
parallelize_loop()
now returns a future in the form of a newBS::multi_future
helper class template. The member functionwait()
of this future allows waiting until all of the loop's blocks finish executing. In previous versions, callingparallelize_loop()
both parallelized the loop and waited for the blocks to finish; now it is possible to do other stuff while the loop executes.- API migration: Since
parallelize_loop()
no longer automatically blocks, you should either store the result in aBS::multi_future
object and call itswait()
member function, or simply callparallelize_loop().wait()
to reproduce the old behavior.
- API migration: Since
- The header file has been renamed to
- Non-breaking changes to the library header file:
- It is now possible to use
parallelize_loop()
with functions that have return values and get these values from all blocks at once through theget()
member function of theBS::multi_future
. - The template specializations for
push_task()
have been merged. Now instead of two versions, one for functions with arguments and one for functions without arguments, there is just one version, which can accept any function. - Constructors have been made
explicit
. See issue #28. submit()
now usesstd::make_shared
instead ofnew
to create the shared pointer. This means only one memory allocation is performed instead of two, which should improve performance. In addition, all unique pointers are now created usingstd::make_unique
.- A new helper class template,
BS::multi_future
, has been added. It's basically just a wrapper aroundstd::vector<std::future<T>>
. This class is used by the new implementation ofparallelize_loop()
to allow waiting for the entire loop, consisting of multiple tasks with their corresponding futures, to finish executing. BS::multi_future
can also be used independently to handle multiple futures at once. For example, you can now keep track of several groups of tasks by storing their futures inside separateBS::multi_future
objects and use eitherwait()
to wait for all tasks in a specific group to finish orget()
to get anstd::vector
with the return values of every task in the group.- Integer types are now chosen in a smarter way to improve portability, allow for better compatibility with 32-bit systems, and prevent potential conversion errors.
- Added a new type,
BS::concurrency_t
, equal to the return type ofstd::thread::hardware_concurrency()
. This is probably pointless, since the C++ standard requires this to beunsigned int
, but it seems to me to make the code slightly more portable, in case some non-conforming compiler chooses to use a different integer type. - C-style casts have been converted to C++ cast expressions for added clarity.
- Miscellaneous minor optimizations and style improvements.
- It is now possible to use
- Changes to the test program:
- The program has been renamed to
BS_thread_pool_test.cpp
to avoid potential conflict with other thread pool libraries. - The program now returns
EXIT_FAILURE
if any of the tests failed, for automation purposes. See pull request #42. - Fixed incorrect check order in
check_task_monitoring()
. See pull request #43. - Added a new test for
parallelize_loop()
with a return value. - Improved some of the tests to make them more reliable. For example,
count_unique_threads()
now uses futures (stored in aBS::multi_future<void>
object). - The program now uses
std::vector
instead of matrices, for both consistency checks and benchmarks, in order to simplify the code and considerably reduce its length. - The benchmarks have been simplified. There's now only one test: filling a specific number of vectors of fixed size with random values. This may be replaced with something more practical in a future released, but at least on the systems I've tested on, it does demonstrate a very significant multi-threading speedup.
- In addition to multi-threaded tests with different numbers of tasks, the benchmark now also includes a single-threaded test. This allows for more accurate benchmarks compared to previous versions, as the (slight) parallelization overhead is now taken into account when calculating the maximum speedup.
- The program decides how many vectors to use for benchmarking by testing how many are needed to reach a target duration in the single-threaded test. This ensures that the test takes approximately the same amount of time on different systems, and is thus more consistent and portable.
- Miscellaneous minor optimizations and style improvements.
- The program has been renamed to
- Changes to
README.md
:- Many sections have been rewritten and/or polished.
- Explanations and examples of all the new features have been added.
- Added an acknowledgements section.
- Miscellaneous changes:
- Added a
CITATION.bib
file (in BibTeX format) to the GitHub repository. You can use it to easily cite this package if you use it in any research papers. - Added a
CITATION.cff
file (in YAML format) to the GitHub repository. This should add an option to get a citation in different formats directly from GitHub repository by clicking on "cite this repository" on the sidebar to the right. - Added templates for GitHub issues and pull requests.
- Added a
- From now on, version numbers will adhere to the Semantic Versioning specification in the format major.minor.patch.
- A file named
thread_pool_test.cpp
has been added to the package. It will perform automated tests of all aspects of the package, and benchmark some multithreaded matrix operations. Please run it on your system and submit a bug report if any of the tests fail. In addition, the code is thoroughly documented, and is meant to serve as an extensive example of how to properly use the package. - The package is now available through vcpkg. Instructions for how to install it have been added to
README.md
. See this pull request. - The package now defines a macro
THREAD_POOL_VERSION
, which returns the version number and release date of the thread pool library as a string. parallelize_loop()
has undergone some major changes (and is now incompatible with v1.x):- The second argument is now the index after the last index, instead of the last index itself. This is more consistent with C++ conventions (e.g. standard library algorithms) where the range is always
[first, last)
. For example, for an array withn
indices, instead ofparallelize_loop(0, n - 1, ...)
you should now writeparallelize_loop(0, n, ...)
. - The
loop
function is now only called once per block, instead of once per index, as was the case before. This should provide a performance boost due to significantly reducing the number of function calls, and it also allows you to conserve resources by using them only once per block instead of once per index (an example can be found in therandom_matrix_generator
class inthread_pool_test.cpp
). It also means thatloop
now takes two arguments: the first index in the block and the index after the last index in the block. Thus,loop(start, end)
should typically involve a loop of the formfor (T i = start; i < end; i++)
. - The first and last indices can now be of two different integer types. Previously,
parallelize_loop(0, i, ...)
did not work ifi
was not anint
, because0
was interpreted asint
, and the two arguments had to be of the same type. Therefore, one had to use casting, e.g.parallelize_loop((size_t)0, i)
, to make it work. Now this is no longer necessary; the common type is inferred automatically usingstd::common_type_t
.
- The second argument is now the index after the last index, instead of the last index itself. This is more consistent with C++ conventions (e.g. standard library algorithms) where the range is always
- Fixed a bug in
reset()
which caused it to create the wrong number of threads.
- The version history has become too long to be included in
README.md
, so I moved it to a separate file,CHANGELOG.md
. - A button to open this repository directly in Visual Studio Code has been added to the badges in
README.md
. - An internal variable named
promise
has been renamed totask_promise
to avoid any potential errors in case the user invokesusing namespace std
. submit()
now catches exceptions thrown by the submitted task and forwards them to the future. See this issue.- Eliminated compiler warnings that appeared when using the
-Weffc++
flag in GCC. See this pull request.
- Fixed a bug in
parallelize_loop()
which prevented it from actually running loops in parallel, see this issue.
- Since MSVC does not interpret
and
as&&
by default, the previous release did not compile with MSVC unless the/permissive-
or/Za
compiler flags were used. This has been fixed in this version, and the code now successfully compiles with GCC, Clang, and MSVC. See this pull request.
- This library now has a DOI for citation purposes. Information on how to cite it in publications has been added to the source code and to
README.md
. - Added GitHub badges to
README.md
.
- Added three new public member functions to monitor the tasks submitted to the pool:
get_tasks_queued()
gets the number of tasks currently waiting in the queue to be executed by the threads.get_tasks_running()
gets the number of tasks currently being executed by the threads.get_tasks_total()
gets the total number of unfinished tasks - either still in the queue, or running in a thread.- Note that
get_tasks_running() == get_tasks_total() - get_tasks_queued()
. - Renamed the private member variable
tasks_waiting
totasks_total
to make its purpose clearer.
- Added an option to temporarily pause the workers:
- When public member variable
paused
is set totrue
, the workers temporarily stop popping new tasks out of the queue, although any tasks already executed will keep running until they are done. Set tofalse
again to resume popping tasks. - While the workers are paused,
wait_for_tasks()
will wait for the running tasks instead of all tasks (otherwise it would wait forever). - By utilizing the new pausing mechanism,
reset()
can now change the number of threads on-the-fly while there are still tasks waiting in the queue. The new thread pool will resume executing tasks from the queue once it is created.
- When public member variable
parallelize_loop()
andwait_for_tasks()
now have the same behavior as the worker function with regards to waiting for tasks to complete. If the relevant tasks are not yet complete, then before checking again, they will sleep forsleep_duration
microseconds, unless that variable is set to zero, in which case they will callstd::this_thread::yield()
. This should improve performance and reduce CPU usage.- Merged this commit: Fixed weird error when using MSVC and including
windows.h
. - The
README.md
file has been reorganized and expanded.
- Fixed this issue: Removed
std::move
from thereturn
statement inpush_task()
. This previously generated a-Wpessimizing-move
warning in Clang. The assembly code generated by the compiler seems to be the same before and after this change, presumably because the compiler eliminates thestd::move
automatically, but this change gets rid of the Clang warning. - Fixed this issue: Removed a debugging message printed to
std::cout
, which was left in the code by mistake. - Fixed this issue:
parallelize_loop()
no longer sends references for the variablesstart
andstop
when callingpush_task()
, which may lead to undefined behavior. - A companion paper is now published at arXiv:2105.00613, including additional information such as performance tests on systems with up to 80 hardware threads. The
README.md
has been updated, and it is now roughly identical in content to the paper.
- The worker function, which controls the execution of tasks by each thread, now sleeps by default instead of yielding. Previously, when the worker could not find any tasks in the queue, it called
std::this_thread::yield()
and then tried again. However, this caused the workers to have high CPU usage when idle, as reported by some users. Now, when the worker function cannot find a task to run, it instead sleeps for a duration given by the public member variablesleep_duration
(in microseconds) before checking the queue again. The default value is1000
microseconds, which I found to be optimal in terms of both CPU usage and performance, but your own optimal value may be different. - If the constructor is called with an argument of zero for the number of threads, then the default value,
std::thread::hardware_concurrency()
, is used instead. - Added a simple helper class,
timer
, which can be used to measure execution time for benchmarking purposes. - Improved and expanded the documentation.
- Cosmetic changes only. Fixed a typo in the Doxygen comments and added a link to the GitHub repository.
- Initial release.