Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TA#70368 [ADD] project_material_enhanced : detailed consumption #438

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

lanto-razafindrabe
Copy link
Contributor

No description provided.

Copy link

codacy-production bot commented Oct 23, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7e80395) 4798 4650 96.92%
Head commit (9cf11d9) 4841 (+43) 4693 (+43) 96.94% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#438) 43 43 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@abenzbiria
Copy link
Contributor

Hi @lanto-razafindrabe ,

why you did not use the free_qty field to compute the available qty - reserved one ?

TA#70368 [ADD] project_material_enhanced : detailed consumption

Update project_task_material.py
@lanto-razafindrabe
Copy link
Contributor Author

Hi @lanto-razafindrabe ,

why you did not use the free_qty field to compute the available qty - reserved one ?

Hi @abenzbiria
It has been recommended the use of https://github.com/OCA/stock-logistics-warehouse/tree/14.0/stock_available_unreserved. But as we have seen together, it made confusion as it was just a module migrated from older version that had not the free_qty field in Odoo stock core module.

I updated the PR. We use now free_qty.

Thank you

@abenzbiria abenzbiria merged commit 527e794 into 14.0 Oct 24, 2024
4 of 5 checks passed
@abenzbiria abenzbiria deleted the TA#70368 branch October 24, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants