Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.11] python311Packages.notebook: 7.0.6 -> 7.0.8 #303093

Merged
merged 2 commits into from
Apr 13, 2024

Conversation

natsukium
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@natsukium natsukium added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Apr 10, 2024
@ofborg ofborg bot requested review from thomasjm and GaetanLepage April 10, 2024 12:40
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Apr 10, 2024
@LeSuisse
Copy link
Contributor

Could you please backport the 2 commits with git cherry-pick -x ... so the commit message contains the original commit hash (that's why the Check cherry-picks workflow is unhappy)?

https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#manually-backporting-changes

Also this has been flagged with the Security label and I'm not sure why. The changelog does not seem to mention a security issue https://github.com/jupyter/notebook/blob/v7.0.8/CHANGELOG.md and I cannot find something related to these versions in their advisories. Can you clarify? Thanks!

@risicle
Copy link
Contributor

risicle commented Apr 10, 2024

(FWIW I think the script is malfunctioning - a commit with no mention of cherry-picks should be ignored - will take a look...)

@natsukium
Copy link
Member Author

I had a problem with cherry picking. Thanks for letting me know.

I'm not sure if there is an actual problem, but looking at the repology, the following two CVEs were mentioned.
https://nvd.nist.gov/vuln/detail/CVE-2024-22420
https://nvd.nist.gov/vuln/detail/CVE-2024-22421

Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review happy on Linux x86_64, opened Jupyter notebook with notebook with no issue.

Result of nixpkgs-review pr 303093 run on x86_64-linux 1

12 packages marked as broken and skipped:
  • python310Packages.elegy
  • python310Packages.elegy.dist
  • python310Packages.jupyter-contrib-nbextensions
  • python310Packages.jupyter-contrib-nbextensions.dist
  • python310Packages.treex
  • python310Packages.treex.dist
  • python311Packages.elegy
  • python311Packages.elegy.dist
  • python311Packages.jupyter-contrib-nbextensions
  • python311Packages.jupyter-contrib-nbextensions.dist
  • python311Packages.treex
  • python311Packages.treex.dist
1 package failed to build:
  • wolfram-notebook
184 packages built:
  • cantor (libsForQt5.cantor ,plasma5Packages.cantor)
  • ihaskell
  • jupyter
  • jupyter-all
  • labplot
  • nbqa
  • nbqa.dist
  • python310Packages.ansible-kernel
  • python310Packages.ansible-kernel.dist
  • python310Packages.arviz
  • python310Packages.arviz.dist
  • python310Packages.augmax
  • python310Packages.augmax.dist
  • python310Packages.bambi
  • python310Packages.bambi.dist
  • python310Packages.batchspawner
  • python310Packages.batchspawner.dist
  • python310Packages.dalle-mini
  • python310Packages.dalle-mini.dist
  • python310Packages.dockerspawner
  • python310Packages.dockerspawner.dist
  • python310Packages.einops
  • python310Packages.einops.dist
  • python310Packages.encodec
  • python310Packages.encodec.dist
  • python310Packages.experiment-utilities
  • python310Packages.experiment-utilities.dist
  • python310Packages.flax
  • python310Packages.flax.dist
  • python310Packages.jupyter
  • python310Packages.jupyter-contrib-core
  • python310Packages.jupyter-contrib-core.dist
  • python310Packages.jupyter-nbextensions-configurator
  • python310Packages.jupyter-nbextensions-configurator.dist
  • python310Packages.jupyter.dist
  • python310Packages.jupyterhub
  • python310Packages.jupyterhub-ldapauthenticator
  • python310Packages.jupyterhub-ldapauthenticator.dist
  • python310Packages.jupyterhub-systemdspawner
  • python310Packages.jupyterhub-systemdspawner.dist
  • python310Packages.jupyterhub-tmpauthenticator
  • python310Packages.jupyterhub-tmpauthenticator.dist
  • python310Packages.jupyterhub.dist
  • python310Packages.jupyterlab-git
  • python310Packages.jupyterlab-git.dist
  • python310Packages.jupytext
  • python310Packages.jupytext.dist
  • python310Packages.k-diffusion
  • python310Packages.k-diffusion.dist
  • python310Packages.mkdocs-jupyter
  • python310Packages.mkdocs-jupyter.dist
  • python310Packages.nbdev
  • python310Packages.nbdev.dist
  • python310Packages.nbdime
  • python310Packages.nbdime.dist
  • python310Packages.nikola
  • python310Packages.nikola.dist
  • python310Packages.nix-kernel
  • python310Packages.nix-kernel.dist
  • python310Packages.notebook
  • python310Packages.notebook.dist
  • python310Packages.notedown
  • python310Packages.notedown.dist
  • python310Packages.oauthenticator
  • python310Packages.oauthenticator.dist
  • python310Packages.openllm
  • python310Packages.openllm.dist
  • python310Packages.phik
  • python310Packages.phik.dist
  • python310Packages.pydeck
  • python310Packages.pydeck.dist
  • python310Packages.pymc
  • python310Packages.pymc.dist
  • python310Packages.pymoo
  • python310Packages.pymoo.dist
  • python310Packages.qgrid
  • python310Packages.qgrid.dist
  • python310Packages.rotary-embedding-torch
  • python310Packages.rotary-embedding-torch.dist
  • python310Packages.streamlit
  • python310Packages.streamlit.dist
  • python310Packages.tsfresh
  • python310Packages.tsfresh.dist
  • python310Packages.vector
  • python310Packages.vector.dist
  • python310Packages.vega
  • python310Packages.vega.dist
  • python310Packages.vqgan-jax
  • python310Packages.vqgan-jax.dist
  • python310Packages.xarray-einstats
  • python310Packages.xarray-einstats.dist
  • python311Packages.ansible-kernel
  • python311Packages.ansible-kernel.dist
  • python311Packages.arviz
  • python311Packages.arviz.dist
  • python311Packages.augmax
  • python311Packages.augmax.dist
  • python311Packages.bambi
  • python311Packages.bambi.dist
  • python311Packages.batchspawner
  • python311Packages.batchspawner.dist
  • python311Packages.dalle-mini
  • python311Packages.dalle-mini.dist
  • python311Packages.dockerspawner
  • python311Packages.dockerspawner.dist
  • python311Packages.einops
  • python311Packages.einops.dist
  • python311Packages.encodec
  • python311Packages.encodec.dist
  • python311Packages.experiment-utilities
  • python311Packages.experiment-utilities.dist
  • python311Packages.flax
  • python311Packages.flax.dist
  • python311Packages.jupyter
  • python311Packages.jupyter-contrib-core
  • python311Packages.jupyter-contrib-core.dist
  • python311Packages.jupyter-nbextensions-configurator
  • python311Packages.jupyter-nbextensions-configurator.dist
  • python311Packages.jupyter.dist
  • python311Packages.jupyterhub
  • python311Packages.jupyterhub-ldapauthenticator
  • python311Packages.jupyterhub-ldapauthenticator.dist
  • python311Packages.jupyterhub-systemdspawner
  • python311Packages.jupyterhub-systemdspawner.dist
  • python311Packages.jupyterhub-tmpauthenticator
  • python311Packages.jupyterhub-tmpauthenticator.dist
  • python311Packages.jupyterhub.dist
  • python311Packages.jupyterlab-git
  • python311Packages.jupyterlab-git.dist
  • python311Packages.jupytext
  • python311Packages.jupytext.dist
  • python311Packages.k-diffusion
  • python311Packages.k-diffusion.dist
  • python311Packages.mkdocs-jupyter
  • python311Packages.mkdocs-jupyter.dist
  • python311Packages.nbdev
  • python311Packages.nbdev.dist
  • python311Packages.nbdime
  • python311Packages.nbdime.dist
  • python311Packages.nikola
  • python311Packages.nikola.dist
  • python311Packages.nix-kernel
  • python311Packages.nix-kernel.dist
  • python311Packages.notebook
  • python311Packages.notebook.dist
  • python311Packages.notedown
  • python311Packages.notedown.dist
  • python311Packages.oauthenticator
  • python311Packages.oauthenticator.dist
  • python311Packages.openllm
  • python311Packages.openllm.dist
  • python311Packages.phik
  • python311Packages.phik.dist
  • python311Packages.pydeck
  • python311Packages.pydeck.dist
  • python311Packages.pymc
  • python311Packages.pymc.dist
  • python311Packages.pymoo
  • python311Packages.pymoo.dist
  • python311Packages.qgrid
  • python311Packages.qgrid.dist
  • python311Packages.rotary-embedding-torch
  • python311Packages.rotary-embedding-torch.dist
  • streamlit (python311Packages.streamlit)
  • streamlit.dist (python311Packages.streamlit.dist)
  • python311Packages.tsfresh
  • python311Packages.tsfresh.dist
  • python311Packages.vector
  • python311Packages.vector.dist
  • python311Packages.vega
  • python311Packages.vega.dist
  • python311Packages.vqgan-jax
  • python311Packages.vqgan-jax.dist
  • python311Packages.xarray-einstats
  • python311Packages.xarray-einstats.dist
  • quarto
  • rstudio
  • rstudio-server
  • rstudioServerWrapper
  • rstudioWrapper
  • sage
  • sageWithDoc
  • tts
  • tts.dist

@LeSuisse LeSuisse merged commit 70850f7 into NixOS:release-23.11 Apr 13, 2024
22 checks passed
@natsukium natsukium deleted the notebook/backport branch April 14, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants