Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation]: Update text describing LFP and FilteredEphys in ecephys tutorial. #2005

Open
3 tasks done
ehennestad opened this issue Nov 21, 2024 · 6 comments
Open
3 tasks done
Labels
category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) topic: docs issues related to documentation

Comments

@ehennestad
Copy link

ehennestad commented Nov 21, 2024

What would you like changed or added to the documentation and why?

I am working through the matnwb tutorial and the following seems inaccurate:

About LFP:

LFP data is typically considered processed data because the raw data was filtered and downsampled to generate the LFP.

About FilteredEphys

If the derived data is filtered, but not downsampled, you can store the data in an ElectricalSeries object in a FilteredEphys object instead of a object.

Filtered ephys refers to filtering in general, and does not concern resampling. The schema description seems accurate:

Overview: Electrophysiology data from one or more channels that has been subjected to filtering. Examples of filtered data include Theta and Gamma (LFP has its own interface).

https://nwb-schema.readthedocs.io/en/latest/format.html#filteredephys

Suggestions for new text [edited]

LFP:
LFP refers to data that has been low-pass filtered, typically below 300 Hz. This data may also be downsampled. Because it is filtered and potentially resampled, it is categorized as processed data.

FilteredEphys:
If your data is filtered for frequency ranges other than LFP—such as Gamma or Theta—you should store it in an ElectricalSeries and encapsulate it within a FilteredEphys object.

@bendichter @stephprince @oruebel
Please let me know your opinions

Do you have any interest in helping write or edit the documentation?

Yes.

Code of Conduct

@ehennestad
Copy link
Author

From the documentation:

Filter properties should be noted in the ElectricalSeries ‘filtering’ attribute.
https://nwb-schema.readthedocs.io/en/latest/format.html#lfp

This seems like a key property that should be highlighted and exemplified in these examples

@bendichter
Copy link
Contributor

bendichter commented Nov 21, 2024 via email

@stephprince
Copy link
Contributor

If the derived data is filtered, but not downsampled, you can store the data in an ElectricalSeries object in a FilteredEphys object instead of a object.

Filtered ephys refers to filtering in general, and does not concern resampling.

I think you're suggesting we remove the "but not downsampled" statement? If so I agree, in my experience at least theta/gamma filtering is often applied to the downsampled LFP data, and filtered ephys should not concern resampling.

I think demonstrating the filtering attribute is also a good idea!

@stephprince stephprince added category: enhancement improvements of code or code behavior topic: docs issues related to documentation priority: low alternative solution already working and/or relevant to only specific user(s) labels Nov 21, 2024
@rly
Copy link
Contributor

rly commented Nov 22, 2024

Just to add:

I like @ehennestad 's proposed new text. For FilteredEphys, if it's not clear in the surrounding text, it should be made clear that that is typically also considered processed data...

I also think demonstrating the filtering attribute is a good idea.

@ehennestad
Copy link
Author

ehennestad commented Nov 22, 2024

You can also store multiple filtered time series data in a single DecompositionSeries object

I think the decomposition series is meant for the results of spectral analysis, which is a different operation than filtering

For FilteredEphys, if it's not clear in the surrounding text, it should be made clear that that is typically also considered processed data...

good point!

@rly
Copy link
Contributor

rly commented Nov 22, 2024

I think the decomposition series is meant for the results of spectral analysis, which is a different operation than filtering

You are right! My mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) topic: docs issues related to documentation
Projects
None yet
Development

No branches or pull requests

4 participants