-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation]: Update text describing LFP and FilteredEphys in ecephys tutorial. #2005
Comments
From the documentation:
This seems like a key property that should be highlighted and exemplified in these examples |
Oh yeah good point!
Ben Dichter, PhD
Data Science Consultant
personal website <http://bendichter.com/>
…On Thu, Nov 21, 2024 at 12:47 PM ehennestad ***@***.***> wrote:
From the documentation:
Filter properties should be noted in the ElectricalSeries ‘filtering’
attribute.
https://nwb-schema.readthedocs.io/en/latest/format.html#lfp
This seems like a key property that should be highlighted and exemplified
in these examples
—
Reply to this email directly, view it on GitHub
<#2005 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGOEERCMTOI323MCXGG5WD2BXB5NAVCNFSM6AAAAABSGYUUGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJQHEYDKNBTHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I think you're suggesting we remove the "but not downsampled" statement? If so I agree, in my experience at least theta/gamma filtering is often applied to the downsampled LFP data, and filtered ephys should not concern resampling. I think demonstrating the |
Just to add:
I like @ehennestad 's proposed new text. For I also think demonstrating the |
I think the decomposition series is meant for the results of spectral analysis, which is a different operation than filtering
good point! |
You are right! My mistake. |
What would you like changed or added to the documentation and why?
I am working through the matnwb tutorial and the following seems inaccurate:
About LFP:
About FilteredEphys
Filtered ephys refers to filtering in general, and does not concern resampling. The schema description seems accurate:
https://nwb-schema.readthedocs.io/en/latest/format.html#filteredephys
Suggestions for new text [edited]
LFP:
LFP refers to data that has been low-pass filtered, typically below 300 Hz. This data may also be downsampled. Because it is filtered and potentially resampled, it is categorized as processed data.
FilteredEphys:
If your data is filtered for frequency ranges other than LFP—such as Gamma or Theta—you should store it in an ElectricalSeries and encapsulate it within a FilteredEphys object.
@bendichter @stephprince @oruebel
Please let me know your opinions
Do you have any interest in helping write or edit the documentation?
Yes.
Code of Conduct
The text was updated successfully, but these errors were encountered: