This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Any reason for Conductor Monitors being a concrete class #2501
Answered
by
kishorebanala
taoj-action
asked this question in
Q&A
-
|
Monitors.java is a concrete class that creates a hard dependency on Netflix spectator. It could be more flexible to define an interface instead of those DAOs and let end-user configure different metrics solutions. |
Beta Was this translation helpful? Give feedback.
Answered by
kishorebanala
Oct 4, 2021
Replies: 2 comments
-
|
@taojwmware +1, please send us a PR if you have bandwidth to do this. Thanks! |
Beta Was this translation helpful? Give feedback.
0 replies
Answer selected by
taoj-action
-
|
I am taking a small step first by cleanup Server dependency by removing unused code. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@taojwmware +1, please send us a PR if you have bandwidth to do this. Thanks!